src/pkg/runtime/proc.c - Issue 127490043: code review 127490043: runtime: convert Gosched to Go

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/runtime/proc.c

Issue 127490043: code review 127490043: runtime: convert Gosched to Go (Closed)

Patch Set: diff -r e34ca40b4857b9ba020e0cacf182044599cb0a1a https://dvyukov%40google.com@code.google.com/p/go/ Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/runtime/proc.c

===================================================================

--- a/src/pkg/runtime/proc.c

+++ b/src/pkg/runtime/proc.c

@@ -1449,15 +1449,15 @@

void

runtime·gosched(void)

{

- if(g->status != Grunning)

- runtime·throw("bad g status");

- runtime·mcall(runtime·gosched0);

+ runtime·mcall(runtime·gosched_m);

}

// runtime·gosched continuation on g0.

void

-runtime·gosched0(G *gp)

+runtime·gosched_m(G *gp)

{

+ if(gp->status != Grunning)

+ runtime·throw("bad g status");

gp->status = Grunnable;

dropg();

runtime·lock(&runtime·sched.lock);

@@ -2055,12 +2055,6 @@

runtime·breakpoint();

}

-void

-runtime·Gosched(void)

- runtime·gosched();

// Implementation of runtime.GOMAXPROCS.

// delete when scheduler is even stronger

int32

« no previous file with comments | « src/pkg/runtime/extern.go ('k') | src/pkg/runtime/proc.go » ('j') | no next file with comments »