Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(165)

Issue 127170043: [dev.power64] code review 127170043: syscall: auto-generated source for linux/power64 and li... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by minux
Modified:
6 years, 5 months ago
Reviewers:
rsc
CC:
rsc, iant, golang-codereviews
Visibility:
Public.

Description

syscall: auto-generated source for linux/power64 and linux/power64le.

Patch Set 1 #

Patch Set 2 : diff -r 374c2eb01bdb2388e0291ae405439c3c0990ff9c https://code.google.com/p/go #

Patch Set 3 : diff -r 374c2eb01bdb2388e0291ae405439c3c0990ff9c https://code.google.com/p/go #

Patch Set 4 : diff -r 374c2eb01bdb2388e0291ae405439c3c0990ff9c https://code.google.com/p/go #

Patch Set 5 : diff -r 374c2eb01bdb2388e0291ae405439c3c0990ff9c https://code.google.com/p/go #

Patch Set 6 : diff -r bdaa8020e5797a2a59b6d5932daec0d4d4c1da90 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9566 lines, -0 lines) Patch
A src/pkg/syscall/zerrors_linux_power64.go View 1 1 chunk +1887 lines, -0 lines 0 comments Download
A src/pkg/syscall/zerrors_linux_power64le.go View 1 1 chunk +1911 lines, -0 lines 0 comments Download
A src/pkg/syscall/zsyscall_linux_power64.go View 1 2 3 1 chunk +1931 lines, -0 lines 0 comments Download
A src/pkg/syscall/zsyscall_linux_power64le.go View 1 2 3 1 chunk +1931 lines, -0 lines 0 comments Download
A src/pkg/syscall/zsysnum_linux_power64.go View 1 1 chunk +351 lines, -0 lines 0 comments Download
A src/pkg/syscall/zsysnum_linux_power64le.go View 1 1 chunk +351 lines, -0 lines 0 comments Download
A src/pkg/syscall/ztypes_linux_power64.go View 1 1 chunk +602 lines, -0 lines 0 comments Download
A src/pkg/syscall/ztypes_linux_power64le.go View 1 1 chunk +602 lines, -0 lines 0 comments Download

Messages

Total messages: 8
minux
Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to the dev.power64 ...
6 years, 5 months ago (2014-08-12 19:08:15 UTC) #1
rsc
Are these different between power64 and power64le? Should they be power64x too?
6 years, 5 months ago (2014-08-12 19:26:07 UTC) #2
minux
On Tue, Aug 12, 2014 at 3:26 PM, <rsc@golang.org> wrote: > Are these different between ...
6 years, 5 months ago (2014-08-12 19:47:09 UTC) #3
rsc
Ok On Tuesday, August 12, 2014, minux <minux@golang.org> wrote: > > On Tue, Aug 12, ...
6 years, 5 months ago (2014-08-12 19:56:38 UTC) #4
minux
On Tue, Aug 12, 2014 at 3:56 PM, Russ Cox <rsc@golang.org> wrote: > Ok I ...
6 years, 5 months ago (2014-08-12 19:59:55 UTC) #5
minux
Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 5 months ago (2014-08-12 22:00:01 UTC) #6
rsc
LGTM
6 years, 5 months ago (2014-08-12 22:03:01 UTC) #7
minux
6 years, 5 months ago (2014-08-12 23:49:23 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=4a21ca18b77f ***

[dev.power64] syscall: auto-generated source for linux/power64 and
linux/power64le.

LGTM=rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/127170043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b