Code review - Issue 127170043: [dev.power64] code review 127170043: syscall: auto-generated source for linux/power64 and li...https://codereview.appspot.com/2014-08-12T23:49:23+00:00rietveld
Message from unknown
2014-08-12T18:46:04+00:00minuxurn:md5:c57f75c398eed23bd342c2cbca7e6c5c
Message from unknown
2014-08-12T18:46:07+00:00minuxurn:md5:cfe63a8f15f7425c2152e0d47cecbd43
Message from unknown
2014-08-12T19:08:10+00:00minuxurn:md5:b19af5588fb89ffe61c0cd9e8e8bd287
Message from minux@golang.org
2014-08-12T19:08:15+00:00minuxurn:md5:3b4f8748884fc22a5b90877f8f3c5087
Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),
I'd like you to review this change to the dev.power64 branch of
https://code.google.com/p/go
Message from rsc@golang.org
2014-08-12T19:26:07+00:00rscurn:md5:9597823d8d647cc6fd0c86be3a5bc225
Are these different between power64 and power64le? Should they be power64x too?
Message from minux@golang.org
2014-08-12T19:47:09+00:00minuxurn:md5:9db731edb4ecea5ff20b676a1ffe5927
On Tue, Aug 12, 2014 at 3:26 PM, <rsc@golang.org> wrote:
> Are these different between power64 and power64le? Should they be
> power64x too?
>
--- pkg/syscall/ztypes_linux_power64.go 2014-08-12 14:42:56.394593099 -0400
+++ pkg/syscall/ztypes_linux_power64le.go 2014-08-12
14:42:56.394593099 -0400
@@ -97,23 +97,23 @@
type _Gid_t uint32
type Stat_t struct {
- Dev uint64
- Ino uint64
- Nlink uint64
- Mode uint32
- Uid uint32
- Gid uint32
- X__pad2 int32
- Rdev uint64
- Size int64
- Blksize int64
- Blocks int64
- Atim Timespec
- Mtim Timespec
- Ctim Timespec
- X__unused4 uint64
- X__unused5 uint64
- X__unused6 uint64
+ Dev uint64
+ Ino uint64
+ Nlink uint64
+ Mode uint32
+ Uid uint32
+ Gid uint32
+ X__pad2 int32
+ Rdev uint64
+ Size int64
+ Blksize int64
+ Blocks int64
+ Atim Timespec
+ Mtim Timespec
+ Ctim Timespec
+ X__glibc_reserved4 uint64
+ X__glibc_reserved5 uint64
+ X__glibc_reserved6 uint64
}
type Statfs_t struct {
--- pkg/syscall/zerrors_linux_power64.go 2014-08-12 14:42:56.394593099 -0400
+++ pkg/syscall/zerrors_linux_power64le.go 2014-08-12 14:42:56.394593099
-0400
@@ -30,7 +30,7 @@
AF_KEY = 0xf
AF_LLC = 0x1a
AF_LOCAL = 0x1
- AF_MAX = 0x28
+ AF_MAX = 0x29
AF_NETBEUI = 0xd
AF_NETLINK = 0x10
AF_NETROM = 0x6
@@ -47,6 +47,7 @@
AF_TIPC = 0x1e
AF_UNIX = 0x1
AF_UNSPEC = 0x0
+ AF_VSOCK = 0x28
AF_WANPIPE = 0x19
AF_X25 = 0x9
ARPHRD_ADAPT = 0x108
@@ -263,7 +264,6 @@
EPOLL_CTL_ADD = 0x1
EPOLL_CTL_DEL = 0x2
EPOLL_CTL_MOD = 0x3
- EPOLL_NONBLOCK = 0x800
ETH_P_1588 = 0x88f7
ETH_P_8021AD = 0x88a8
ETH_P_8021AH = 0x88e7
@@ -494,6 +494,7 @@
IN_Q_OVERFLOW = 0x4000
IN_UNMOUNT = 0x2000
IPPROTO_AH = 0x33
+ IPPROTO_BEETPH = 0x5e
IPPROTO_COMP = 0x6c
IPPROTO_DCCP = 0x21
IPPROTO_DSTOPTS = 0x3c
@@ -510,6 +511,7 @@
IPPROTO_IP = 0x0
IPPROTO_IPIP = 0x4
IPPROTO_IPV6 = 0x29
+ IPPROTO_MH = 0x87
IPPROTO_MTP = 0x5c
IPPROTO_NONE = 0x3b
IPPROTO_PIM = 0x67
@@ -663,6 +665,8 @@
MAP_FIXED = 0x10
MAP_GROWSDOWN = 0x100
MAP_HUGETLB = 0x40000
+ MAP_HUGE_MASK = 0x3f
+ MAP_HUGE_SHIFT = 0x1a
MAP_LOCKED = 0x80
MAP_NONBLOCK = 0x10000
MAP_NORESERVE = 0x40
@@ -819,6 +823,7 @@
O_RDWR = 0x2
O_RSYNC = 0x101000
O_SYNC = 0x101000
+ O_TMPFILE = 0x410000
O_TRUNC = 0x200
O_WRONLY = 0x1
PACKET_ADD_MEMBERSHIP = 0x1
@@ -1387,8 +1392,15 @@
TCIOFLUSH = 0x2
TCOFLUSH = 0x1
TCP_CONGESTION = 0xd
+ TCP_COOKIE_IN_ALWAYS = 0x1
+ TCP_COOKIE_MAX = 0x10
+ TCP_COOKIE_MIN = 0x8
+ TCP_COOKIE_OUT_NEVER = 0x2
+ TCP_COOKIE_PAIR_SIZE = 0x20
+ TCP_COOKIE_TRANSACTIONS = 0xf
TCP_CORK = 0x3
TCP_DEFER_ACCEPT = 0x9
+ TCP_FASTOPEN = 0x17
TCP_INFO = 0xb
TCP_KEEPCNT = 0x6
TCP_KEEPIDLE = 0x4
@@ -1400,9 +1412,21 @@
TCP_MD5SIG = 0xe
TCP_MD5SIG_MAXKEYLEN = 0x50
TCP_MSS = 0x200
+ TCP_MSS_DEFAULT = 0x218
+ TCP_MSS_DESIRED = 0x4c4
TCP_NODELAY = 0x1
+ TCP_QUEUE_SEQ = 0x15
TCP_QUICKACK = 0xc
+ TCP_REPAIR = 0x13
+ TCP_REPAIR_OPTIONS = 0x16
+ TCP_REPAIR_QUEUE = 0x14
TCP_SYNCNT = 0x7
+ TCP_S_DATA_IN = 0x4
+ TCP_S_DATA_OUT = 0x8
+ TCP_THIN_DUPACK = 0x11
+ TCP_THIN_LINEAR_TIMEOUTS = 0x10
+ TCP_TIMESTAMP = 0x18
+ TCP_USER_TIMEOUT = 0x12
TCP_WINDOW_CLAMP = 0xa
TCSAFLUSH = 0x2
TIOCCBRK = 0x5428
@@ -1831,7 +1855,7 @@
113: "no route to host",
114: "operation already in progress",
115: "operation now in progress",
- 116: "stale NFS file handle",
+ 116: "stale file handle",
117: "structure needs cleaning",
118: "not a XENIX named type file",
119: "no XENIX semaphores available",
Message from rsc@golang.org
2014-08-12T19:56:38+00:00rscurn:md5:91ebc15283c8be55477d87143118c4c9
Ok
On Tuesday, August 12, 2014, minux <minux@golang.org> wrote:
>
> On Tue, Aug 12, 2014 at 3:26 PM, <rsc@golang.org
> <javascript:_e(%7B%7D,'cvml','rsc@golang.org');>> wrote:
>
>> Are these different between power64 and power64le? Should they be
>> power64x too?
>>
> --- pkg/syscall/ztypes_linux_power64.go 2014-08-12 14:42:56.394593099 -0400
> +++ pkg/syscall/ztypes_linux_power64le.go 2014-08-12
> 14:42:56.394593099 -0400
> @@ -97,23 +97,23 @@
> type _Gid_t uint32
>
> type Stat_t struct {
> - Dev uint64
> - Ino uint64
> - Nlink uint64
> - Mode uint32
> - Uid uint32
> - Gid uint32
> - X__pad2 int32
> - Rdev uint64
> - Size int64
> - Blksize int64
> - Blocks int64
> - Atim Timespec
> - Mtim Timespec
> - Ctim Timespec
> - X__unused4 uint64
> - X__unused5 uint64
> - X__unused6 uint64
> + Dev uint64
> + Ino uint64
> + Nlink uint64
> + Mode uint32
> + Uid uint32
> + Gid uint32
> + X__pad2 int32
> + Rdev uint64
> + Size int64
> + Blksize int64
> + Blocks int64
> + Atim Timespec
> + Mtim Timespec
> + Ctim Timespec
> + X__glibc_reserved4 uint64
> + X__glibc_reserved5 uint64
> + X__glibc_reserved6 uint64
> }
>
> type Statfs_t struct {
>
> --- pkg/syscall/zerrors_linux_power64.go 2014-08-12 14:42:56.394593099
> -0400
> +++ pkg/syscall/zerrors_linux_power64le.go 2014-08-12 14:42:56.394593099
> -0400
> @@ -30,7 +30,7 @@
> AF_KEY = 0xf
> AF_LLC = 0x1a
> AF_LOCAL = 0x1
> - AF_MAX = 0x28
> + AF_MAX = 0x29
> AF_NETBEUI = 0xd
> AF_NETLINK = 0x10
> AF_NETROM = 0x6
> @@ -47,6 +47,7 @@
> AF_TIPC = 0x1e
> AF_UNIX = 0x1
> AF_UNSPEC = 0x0
> + AF_VSOCK = 0x28
> AF_WANPIPE = 0x19
> AF_X25 = 0x9
> ARPHRD_ADAPT = 0x108
> @@ -263,7 +264,6 @@
> EPOLL_CTL_ADD = 0x1
> EPOLL_CTL_DEL = 0x2
> EPOLL_CTL_MOD = 0x3
> - EPOLL_NONBLOCK = 0x800
> ETH_P_1588 = 0x88f7
> ETH_P_8021AD = 0x88a8
> ETH_P_8021AH = 0x88e7
> @@ -494,6 +494,7 @@
> IN_Q_OVERFLOW = 0x4000
> IN_UNMOUNT = 0x2000
> IPPROTO_AH = 0x33
> + IPPROTO_BEETPH = 0x5e
> IPPROTO_COMP = 0x6c
> IPPROTO_DCCP = 0x21
> IPPROTO_DSTOPTS = 0x3c
> @@ -510,6 +511,7 @@
> IPPROTO_IP = 0x0
> IPPROTO_IPIP = 0x4
> IPPROTO_IPV6 = 0x29
> + IPPROTO_MH = 0x87
> IPPROTO_MTP = 0x5c
> IPPROTO_NONE = 0x3b
> IPPROTO_PIM = 0x67
> @@ -663,6 +665,8 @@
> MAP_FIXED = 0x10
> MAP_GROWSDOWN = 0x100
> MAP_HUGETLB = 0x40000
> + MAP_HUGE_MASK = 0x3f
> + MAP_HUGE_SHIFT = 0x1a
> MAP_LOCKED = 0x80
> MAP_NONBLOCK = 0x10000
> MAP_NORESERVE = 0x40
> @@ -819,6 +823,7 @@
> O_RDWR = 0x2
> O_RSYNC = 0x101000
> O_SYNC = 0x101000
> + O_TMPFILE = 0x410000
> O_TRUNC = 0x200
> O_WRONLY = 0x1
> PACKET_ADD_MEMBERSHIP = 0x1
> @@ -1387,8 +1392,15 @@
> TCIOFLUSH = 0x2
> TCOFLUSH = 0x1
> TCP_CONGESTION = 0xd
> + TCP_COOKIE_IN_ALWAYS = 0x1
> + TCP_COOKIE_MAX = 0x10
> + TCP_COOKIE_MIN = 0x8
> + TCP_COOKIE_OUT_NEVER = 0x2
> + TCP_COOKIE_PAIR_SIZE = 0x20
> + TCP_COOKIE_TRANSACTIONS = 0xf
> TCP_CORK = 0x3
> TCP_DEFER_ACCEPT = 0x9
> + TCP_FASTOPEN = 0x17
> TCP_INFO = 0xb
> TCP_KEEPCNT = 0x6
> TCP_KEEPIDLE = 0x4
> @@ -1400,9 +1412,21 @@
> TCP_MD5SIG = 0xe
> TCP_MD5SIG_MAXKEYLEN = 0x50
> TCP_MSS = 0x200
> + TCP_MSS_DEFAULT = 0x218
> + TCP_MSS_DESIRED = 0x4c4
> TCP_NODELAY = 0x1
> + TCP_QUEUE_SEQ = 0x15
> TCP_QUICKACK = 0xc
> + TCP_REPAIR = 0x13
> + TCP_REPAIR_OPTIONS = 0x16
> + TCP_REPAIR_QUEUE = 0x14
> TCP_SYNCNT = 0x7
> + TCP_S_DATA_IN = 0x4
> + TCP_S_DATA_OUT = 0x8
> + TCP_THIN_DUPACK = 0x11
> + TCP_THIN_LINEAR_TIMEOUTS = 0x10
> + TCP_TIMESTAMP = 0x18
> + TCP_USER_TIMEOUT = 0x12
> TCP_WINDOW_CLAMP = 0xa
> TCSAFLUSH = 0x2
> TIOCCBRK = 0x5428
> @@ -1831,7 +1855,7 @@
> 113: "no route to host",
> 114: "operation already in progress",
> 115: "operation now in progress",
> - 116: "stale NFS file handle",
> + 116: "stale file handle",
> 117: "structure needs cleaning",
> 118: "not a XENIX named type file",
> 119: "no XENIX semaphores available",
>
>
>
Message from minux@golang.org
2014-08-12T19:59:55+00:00minuxurn:md5:0479b4d0cbad2268bb6ef2cd5a6a94e0
On Tue, Aug 12, 2014 at 3:56 PM, Russ Cox <rsc@golang.org> wrote:
> Ok
I assume it's ok to merge them into z*_power64x.go?
which version do you want to use for those files that are different?
Message from unknown
2014-08-12T21:58:55+00:00minuxurn:md5:58821fec4dba20deb8f548480738f8dd
Message from unknown
2014-08-12T21:59:53+00:00minuxurn:md5:55a0fb59ca8b6e441dd5cb81179bd42b
Message from minux@golang.org
2014-08-12T22:00:01+00:00minuxurn:md5:39cbe96a1f4d11b9b8eba934353ea885
Hello rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com),
Please take another look.
Message from rsc@golang.org
2014-08-12T22:03:01+00:00rscurn:md5:fa4dab3a11f4c7ee17433622cd69f903
LGTM
Message from unknown
2014-08-12T23:49:10+00:00minuxurn:md5:54200bc3eecefbfd1f66717daa1a66cf
Message from minux@golang.org
2014-08-12T23:49:23+00:00minuxurn:md5:f34d3dae6b3791df393d4bf255420a92
*** Submitted as https://code.google.com/p/go/source/detail?r=4a21ca18b77f ***
[dev.power64] syscall: auto-generated source for linux/power64 and linux/power64le.
LGTM=rsc
R=rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/127170043