Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(186)

Issue 12603044: code review 12603044: encoding/xml: add, support Marshaler interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by rsc
Modified:
4 years, 3 months ago
Reviewers:
kortschak
CC:
golang-dev, iant, kortschak
Visibility:
Public.

Description

encoding/xml: add, support Marshaler interface See golang.org/s/go12xml for design. Fixes issue 2771. Fixes issue 4169. Fixes issue 5975. Fixes issue 6125.

Patch Set 1 #

Patch Set 2 : diff -r 045269edbbee https://code.google.com/p/go/ #

Patch Set 3 : diff -r b20db4bc66df https://code.google.com/p/go/ #

Total comments: 3

Patch Set 4 : diff -r e052a6dba066 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 827764ef09ec https://code.google.com/p/go/ #

Patch Set 6 : diff -r 0794f26827a6 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -99 lines) Patch
M api/go1.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M api/go1.1.txt View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/encoding/xml/marshal.go View 1 2 3 4 16 chunks +372 lines, -91 lines 0 comments Download
M src/pkg/encoding/xml/marshal_test.go View 1 2 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 8
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
4 years, 3 months ago (2013-08-09 15:34:39 UTC) #1
iant
https://codereview.appspot.com/12603044/diff/5001/src/pkg/encoding/xml/marshal.go File src/pkg/encoding/xml/marshal.go (right): https://codereview.appspot.com/12603044/diff/5001/src/pkg/encoding/xml/marshal.go#newcode89 src/pkg/encoding/xml/marshal.go:89: // to encode it uses e.EncodeElement. s/uses/using/ https://codereview.appspot.com/12603044/diff/5001/src/pkg/encoding/xml/marshal.go#newcode98 src/pkg/encoding/xml/marshal.go:98: ...
4 years, 3 months ago (2013-08-09 16:02:45 UTC) #2
rsc
Done.
4 years, 3 months ago (2013-08-09 18:35:45 UTC) #3
rsc
Hello golang-dev@googlegroups.com, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
4 years, 3 months ago (2013-08-13 20:16:24 UTC) #4
kortschak
LGTM
4 years, 3 months ago (2013-08-13 23:28:40 UTC) #5
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=2ca230b93195 *** encoding/xml: add, support Marshaler interface See golang.org/s/go12xml for design. Fixes ...
4 years, 3 months ago (2013-08-14 04:17:46 UTC) #6
rsc
I did not intend to submit this; I pasted the wrong CL number while trying ...
4 years, 3 months ago (2013-08-14 04:19:39 UTC) #7
rsc
4 years, 3 months ago (2013-08-14 04:22:29 UTC) #8
I rolled this CL back. The new pending copy is
https://codereview.appspot.com/12919043. Please leave comments there.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4