Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2937)

Issue 12919043: code review 12919043: encoding/xml: add, support Marshaler interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by rsc
Modified:
10 years, 7 months ago
Reviewers:
shiv
CC:
golang-dev
Visibility:
Public.

Description

encoding/xml: add, support Marshaler interface See golang.org/s/go12xml for design. Repeat of CL 12603044, which was submitted accidentally and then rolled back. Fixes issue 2771. Fixes issue 4169. Fixes issue 5975. Fixes issue 6125.

Patch Set 1 #

Patch Set 2 : diff -r 4204b561812c https://code.google.com/p/go/ #

Patch Set 3 : diff -r add6c198070e https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -99 lines) Patch
M api/go1.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M api/go1.1.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/encoding/xml/marshal.go View 1 16 chunks +372 lines, -91 lines 0 comments Download
M src/pkg/encoding/xml/marshal_test.go View 1 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 8 months ago (2013-08-14 04:22:13 UTC) #1
rsc
The previous copy of this CL was LGTM'ed, so now that the right prereqs are ...
10 years, 8 months ago (2013-08-14 18:58:10 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=7b9e2c29bf14 *** encoding/xml: add, support Marshaler interface See golang.org/s/go12xml for design. Repeat ...
10 years, 8 months ago (2013-08-14 18:58:31 UTC) #3
shiv
On 2013/08/14 18:58:31, rsc wrote: <snip> > Fixes issue 2771. > Fixes issue 4169. > ...
10 years, 7 months ago (2013-08-24 11:28:50 UTC) #4
rsc
10 years, 7 months ago (2013-09-06 19:52:11 UTC) #5
If you want to reproduce the namespace value for Name, you need to record
it. http://play.golang.org/p/RTU3Kk9fLq
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b