Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(184)

Issue 125720044: code review 125720044: runtime: use better hash for non-empty interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rsc
Modified:
10 years, 7 months ago
Reviewers:
khr1, bradfitz
CC:
golang-codereviews, adonovan, khr1, iant, khr, r
Visibility:
Public.

Description

runtime: use better hash for non-empty interface The implementation 'return 0' results in too many collisions.

Patch Set 1 #

Patch Set 2 : diff -r dad4822bccff https://code.google.com/p/go/ #

Patch Set 3 : diff -r dad4822bccff https://code.google.com/p/go/ #

Patch Set 4 : diff -r 37cd24716bed45f655a17ffdc06d769135c77191 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -54 lines) Patch
M src/pkg/runtime/alg.go View 1 1 chunk +16 lines, -1 line 0 comments Download
M src/pkg/runtime/iface.goc View 1 1 chunk +0 lines, -38 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 chunks +13 lines, -15 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-codereviews@googlegroups.com (cc: adonovan, iant, khr, r), I'd like you to review this change to ...
10 years, 7 months ago (2014-08-06 18:15:23 UTC) #1
adonovan
On 2014/08/06 18:15:23, rsc wrote: > Hello mailto:golang-codereviews@googlegroups.com (cc: adonovan, iant, khr, r), > > ...
10 years, 7 months ago (2014-08-06 18:46:01 UTC) #2
rsc
On Wed, Aug 6, 2014 at 2:46 PM, <adonovan@google.com> wrote: > On 2014/08/06 18:15:23, rsc ...
10 years, 7 months ago (2014-08-06 18:49:21 UTC) #3
khr1
LGTM. I have some tests in CL 121030043 that I'll be sure to check in. ...
10 years, 7 months ago (2014-08-06 20:16:12 UTC) #4
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=fc7539d17fd7 *** runtime: use better hash for non-empty interface The implementation 'return ...
10 years, 7 months ago (2014-08-06 20:22:55 UTC) #5
bradfitz
10 years, 7 months ago (2014-08-07 04:50:29 UTC) #6
Thanks. My personal Camlistore server can start up again.

Before this, trying to add 1.5M interface values to a map didn't make it
very far.  :)



On Wed, Aug 6, 2014 at 1:22 PM, <rsc@golang.org> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=fc7539d17fd7 ***
>
>
> runtime: use better hash for non-empty interface
>
> The implementation 'return 0' results in too many collisions.
>
> LGTM=khr
> R=golang-codereviews, adonovan, khr
> CC=golang-codereviews, iant, khr, r
> https://codereview.appspot.com/125720044
>
>
> https://codereview.appspot.com/125720044/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b