code review 125720044: runtime: use better hash for non-empty interface

src/pkg/runtime/iface.goc

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package runtime
 #include "runtime.h"
 #include "arch_GOARCH.h"
 #include "type.h"
 #include "typekind.h"
 #include "malloc.h"
@@ skipping 457 matching lines @@
         }
         ret = e;
 }
 
 func assertE2E2(inter *InterfaceType, e Eface) (ret Eface, ok bool) {
         USED(inter);
         ret = e;
         ok = e.type != nil;
 }
 
-static uintptr
-ifacehash1(void *data, Type *t, uintptr h)
-{
-        Alg *alg;
-        uintptr size;
-        Eface err;
-
-        if(t == nil)
-                return 0;
-
-        alg = t->alg;
-        size = t->size;
-        if(alg->hash->fn == (void(*)())runtime·nohash) {
-                // calling nohash will panic too,
-                // but we can print a better error.
-                runtime·newErrorString(runtime·catstring(runtime·gostringnocopy((byte*)"hash of unhashable type "), *t->string), &err);
-                runtime·panic(err);
-        }
-        if(size <= sizeof(data))
-                return ((uintptr(*)(void**,uintptr,uintptr))alg->hash)(&data, size, h);
-        else
-                return ((uintptr(*)(void*,uintptr,uintptr))alg->hash)(data, size, h);
-}
-
-uintptr
-runtime·ifacehash(Iface a, uintptr h)
-{
-        if(a.tab == nil)
-                return h;
-        return ifacehash1(a.data, a.tab->type, h);
-}
-
-uintptr
-runtime·efacehash(Eface a, uintptr h)
-{
-        return ifacehash1(a.data, a.type, h);
-}
-
 static bool
 ifaceeq1(void *data1, void *data2, Type *t)
 {
         uintptr size;
         Alg *alg;
         Eface err;
         bool eq;
 
         alg = t->alg;
         size = t->size;
@@ skipping 76 matching lines @@
         ret = runtime·cnewarray(t, n);
 }
 
 func reflect·typelinks() (ret Slice) {
         extern Type *typelink[], *etypelink[];
         static int32 first = 1;
         ret.array = (byte*)typelink;
         ret.len = etypelink - typelink;
         ret.cap = ret.len;
 }