Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(783)

Issue 12568043: code review 12568043: cmd/ld: Put the textflag constants in a separate file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by khr
Modified:
10 years, 6 months ago
Reviewers:
r, mischief, rsc, khm
CC:
golang-dev, DMorsing, rsc, khr1
Visibility:
Public.

Description

cmd/ld: Put the textflag constants in a separate file. We can then include this file in assembly to replace cryptic constants like "7" with meaningful constants like "(NOPROF|DUPOK|NOSPLIT)". Converting just pkg/runtime/asm*.s for now. Dropping NOPROF and DUPOK from lots of places where they aren't needed. More .s files to come in a subsequent changelist. A nonzero number in the textflag field now means "has not been converted yet".

Patch Set 1 #

Patch Set 2 : diff -r 1cffbb7333ec https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 3 : diff -r 1cffbb7333ec https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 1cffbb7333ec https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 1cffbb7333ec https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 6 : diff -r d881cb1ffc14 https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -163 lines) Patch
M src/cmd/5l/5.out.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M src/cmd/6l/6.out.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M src/cmd/8l/8.out.h View 1 1 chunk +1 line, -5 lines 0 comments Download
A src/cmd/ld/textflag.h View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M src/pkg/runtime/asm_386.s View 1 2 3 40 chunks +53 lines, -52 lines 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 2 3 44 chunks +64 lines, -63 lines 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 2 3 24 chunks +33 lines, -32 lines 0 comments Download

Messages

Total messages: 14
khr
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
10 years, 7 months ago (2013-08-06 22:18:23 UTC) #1
DMorsing
Does *a support ORing constants?
10 years, 7 months ago (2013-08-07 07:32:56 UTC) #2
rsc
LGTM
10 years, 7 months ago (2013-08-07 13:32:57 UTC) #3
khr1
Yes, they all do. But you need to put the OR in parentheses, like this: ...
10 years, 7 months ago (2013-08-07 16:01:55 UTC) #4
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=cfc3eab6195a *** cmd/ld: Put the textflag constants in a separate file. We ...
10 years, 7 months ago (2013-08-07 17:23:28 UTC) #5
mischief
On 2013/08/07 17:23:28, khr wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=cfc3eab6195a *** > > cmd/ld: Put ...
10 years, 7 months ago (2013-08-13 09:58:44 UTC) #6
rsc
I don't know why this is only breaking on Plan 9. Maybe we pass an ...
10 years, 7 months ago (2013-08-13 13:13:42 UTC) #7
mischief
On Tue, Aug 13, 2013 at 09:13:41AM -0400, Russ Cox wrote: > I don't know ...
10 years, 7 months ago (2013-08-13 14:40:55 UTC) #8
rsc
On Tue, Aug 13, 2013 at 10:40 AM, Nick Owens <mischief@offblast.org> wrote: > hi russ, ...
10 years, 7 months ago (2013-08-13 14:48:57 UTC) #9
khm
On 2013/08/13 14:48:57, rsc wrote: > On Tue, Aug 13, 2013 at 10:40 AM, Nick ...
10 years, 7 months ago (2013-08-13 16:42:59 UTC) #10
rsc
On Tue, Aug 13, 2013 at 12:43 PM, <khm@intma.in> wrote: > I think the bug ...
10 years, 7 months ago (2013-08-13 18:33:43 UTC) #11
khm
On 2013/08/13 18:33:43, rsc wrote: > > that's not the problem here. and plan 9 ...
10 years, 7 months ago (2013-08-13 22:20:24 UTC) #12
rsc
On Tue, Aug 13, 2013 at 6:20 PM, <khm@intma.in> wrote: > On 2013/08/13 18:33:43, rsc ...
10 years, 6 months ago (2013-09-03 19:14:50 UTC) #13
r
10 years, 6 months ago (2013-09-03 21:13:30 UTC) #14
The 9fans list is reporting that it's a bug in include-of-include in 8c.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b