Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1955)

Issue 124820044: code review 124820044: ogle/debug/dwarf: add UnspecifiedType (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by r
Modified:
9 years, 7 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle/debug/dwarf: add UnspecifiedType Also update the handling of complex by clang. See https://codereview.appspot.com/117280043/ and https://codereview.appspot.com/143570043

Patch Set 1 #

Patch Set 2 : diff -r b339cae763795326b80e14627173765485d6d8ba https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M debug/dwarf/type.go View 1 3 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
9 years, 9 months ago (2014-08-06 20:38:36 UTC) #1
nigeltao
LGTM.
9 years, 9 months ago (2014-08-07 02:54:11 UTC) #2
r
9 years, 7 months ago (2014-09-25 17:46:39 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=48ff96b67192 ***

ogle/debug/dwarf: add UnspecifiedType
Also update the handling of complex by clang.
See https://codereview.appspot.com/117280043/
and https://codereview.appspot.com/143570043

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/124820044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b