Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(537)

Issue 143570043: code review 143570043: debug/dwarf: correct name for clang-generated complex type (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rsc
Modified:
9 years, 7 months ago
Reviewers:
iant
CC:
iant, golang-codereviews
Visibility:
Public.

Description

debug/dwarf: correct name for clang-generated complex type Fixes issue 8694.

Patch Set 1 #

Patch Set 2 : diff -r 2f66d595a9ec50db3bf4fe871c6a25a5fff21df3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2f66d595a9ec50db3bf4fe871c6a25a5fff21df3 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 4d89d2fde6304ea3c3605cead44e720019a73f03 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M misc/cgo/test/cgo_test.go View 1 1 chunk +1 line, -0 lines 0 comments Download
A misc/cgo/test/issue8694.go View 1 1 chunk +32 lines, -0 lines 0 comments Download
M src/debug/dwarf/type.go View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello iant (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 7 months ago (2014-09-24 18:52:50 UTC) #1
iant
LGTM
9 years, 7 months ago (2014-09-24 20:36:25 UTC) #2
rsc
9 years, 7 months ago (2014-09-24 20:53:52 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=aac3a857c5d8 ***

debug/dwarf: correct name for clang-generated complex type

Fixes issue 8694.

LGTM=iant
R=iant
CC=golang-codereviews
https://codereview.appspot.com/143570043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b