Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(818)

Issue 123050043: code review 123050043: misc/nacl/testzip.proto: include cmd/internal/* to fix build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by minux
Modified:
10 years, 9 months ago
Reviewers:
rsc, adg, dave
CC:
golang-codereviews, adg, dave_cheney.net
Visibility:
Public.

Description

misc/nacl/testzip.proto: include cmd/internal/* to fix build

Patch Set 1 #

Patch Set 2 : diff -r 66ccfb5353a8281aca6816d5d3a40aacd860638e https://code.google.com/p/go #

Patch Set 3 : diff -r 66ccfb5353a8281aca6816d5d3a40aacd860638e https://code.google.com/p/go #

Patch Set 4 : diff -r 66ccfb5353a8281aca6816d5d3a40aacd860638e https://code.google.com/p/go #

Patch Set 5 : diff -r f16943857e655974f8b776c62b998937ac629801 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M misc/nacl/testzip.proto View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6
minux
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 9 months ago (2014-08-08 00:12:10 UTC) #1
adg
LGTM
10 years, 9 months ago (2014-08-08 00:17:14 UTC) #2
dave_cheney.net
LGTM. Thanks. On Fri, Aug 8, 2014 at 10:16 AM, Andrew Gerrand <adg@golang.org> wrote: > ...
10 years, 9 months ago (2014-08-08 00:22:50 UTC) #3
minux
*** Submitted as https://code.google.com/p/go/source/detail?r=bb9f6c4f6cb3 *** misc/nacl/testzip.proto: include cmd/internal/* to fix build LGTM=adg, dave R=golang-codereviews, adg, ...
10 years, 9 months ago (2014-08-08 01:48:37 UTC) #4
rsc
the zip is already enormous. it will only get even bigger with such a broad ...
10 years, 9 months ago (2014-08-08 01:51:39 UTC) #5
minux
10 years, 9 months ago (2014-08-08 20:57:20 UTC) #6
On Thu, Aug 7, 2014 at 9:51 PM, <rsc@golang.org> wrote:

> the zip is already enormous. it will only get even bigger with such a
> broad rule. can you make it more specific please?
>
Sure. sent https://codereview.appspot.com/126940043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b