LGTM. Thanks. On Fri, Aug 8, 2014 at 10:16 AM, Andrew Gerrand <adg@golang.org> wrote: > ...
10 years, 9 months ago
(2014-08-08 00:22:50 UTC)
#3
LGTM. Thanks.
On Fri, Aug 8, 2014 at 10:16 AM, Andrew Gerrand <adg@golang.org> wrote:
> LGTM
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
*** Submitted as https://code.google.com/p/go/source/detail?r=bb9f6c4f6cb3 *** misc/nacl/testzip.proto: include cmd/internal/* to fix build LGTM=adg, dave R=golang-codereviews, adg, ...
10 years, 9 months ago
(2014-08-08 01:48:37 UTC)
#4
On Thu, Aug 7, 2014 at 9:51 PM, <rsc@golang.org> wrote: > the zip is already ...
10 years, 9 months ago
(2014-08-08 20:57:20 UTC)
#6
On Thu, Aug 7, 2014 at 9:51 PM, <rsc@golang.org> wrote:
> the zip is already enormous. it will only get even bigger with such a
> broad rule. can you make it more specific please?
>
Sure. sent https://codereview.appspot.com/126940043
Issue 123050043: code review 123050043: misc/nacl/testzip.proto: include cmd/internal/* to fix build
(Closed)
Created 10 years, 9 months ago by minux
Modified 10 years, 9 months ago
Reviewers: rsc
Base URL:
Comments: 0