LGTM On Fri, Aug 8, 2014 at 1:56 PM, <minux@golang.org> wrote: > Reviewers: rsc, iant, ...
10 years, 9 months ago
(2014-08-10 18:14:59 UTC)
#2
LGTM
On Fri, Aug 8, 2014 at 1:56 PM, <minux@golang.org> wrote:
> Reviewers: rsc, iant,
>
> Message:
> Hello rsc@golang.org, iant@golang.org (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> misc/nacl/testzip.proto: add less files to the zip
>
> Please review this at https://codereview.appspot.com/126940043/
>
> Affected files (+2, -1 lines):
> M misc/nacl/testzip.proto
>
>
> Index: misc/nacl/testzip.proto
> ===================================================================
> --- a/misc/nacl/testzip.proto
> +++ b/misc/nacl/testzip.proto
> @@ -11,7 +11,8 @@
> src
> cmd
> internal
> - +
> + objfile
> + objfile.go
> gofmt
> testdata
> +
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
*** Submitted as https://code.google.com/p/go/source/detail?r=e02c58028185 *** misc/nacl/testzip.proto: add fewer files to the zip LGTM=bradfitz, rsc R=rsc, ...
10 years, 9 months ago
(2014-08-11 20:56:39 UTC)
#4
Issue 126940043: code review 126940043: misc/nacl/testzip.proto: add fewer files to the zip
(Closed)
Created 10 years, 9 months ago by minux
Modified 10 years, 9 months ago
Reviewers:
Base URL:
Comments: 0