code review 12300043: cmd/api: rewrite using go/types

cmd/api: rewrite using go/types

- adjusted test files so that they actually type-check
- adjusted go1.txt, go1.1.txt, next.txt
- to run, provide build tag: api_tool

Fixes issue 4538.

[gri, 2013-08-07 19:49:18]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-08-07 20:17:32]

Remove the *.old files from the CL


On Wed, Aug 7, 2013 at 12:49 PM, <gri@golang.org> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/api: rewrite using go/types
>
> - renamed previous implementation to *.old for reference
> - adjusted test files so that they actually type-check
> - depends on CL 12578043 (support for fake packages in go/types)
>
> To be submitted when ok and the build scripts have been adjusted.
>
> Please review this at
https://codereview.appspot.**com/12300043/<https://codereview.appspot.com/123...
>
> Affected files:
>   M src/cmd/api/clone.go.old
>   M src/cmd/api/goapi.go
>   M src/cmd/api/goapi.go.old
>   M src/cmd/api/goapi_test.go
>   M src/cmd/api/testdata/src/pkg/**p1/golden.txt
>   M src/cmd/api/testdata/src/pkg/**p1/p1.go
>
>
>

[gri, 2013-08-07 20:26:22]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-08-07 20:43:55]

You also need to add +build tags to all the *.go files so they're not built by
default, except via run.go.

[gri, 2013-08-07 21:08:59]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-08-07 21:47:52]

LGTM but let me submit once run.go is tested and updated.

https://codereview.appspot.com/12300043/diff/67001/src/cmd/api/goapi.go
File src/cmd/api/goapi.go (right):

https://codereview.appspot.com/12300043/diff/67001/src/cmd/api/goapi.go#newco...
src/cmd/api/goapi.go:643: case *types.TypeName:
move this to a new emitType method?  it's big enough.

[gri, 2013-08-07 21:55:03]

https://codereview.appspot.com/12300043/diff/67001/src/cmd/api/goapi.go
File src/cmd/api/goapi.go (right):

https://codereview.appspot.com/12300043/diff/67001/src/cmd/api/goapi.go#newco...
src/cmd/api/goapi.go:643: case *types.TypeName:
On 2013/08/07 21:47:52, bradfitz wrote:
> move this to a new emitType method?  it's big enough.

Done.

[bradfitz, 2013-08-08 00:52:04]

Robert,

You also need to update api/go1.txt (and go1.1.txt if needed) in this CL as
well, correcting its old mistakes.



On Wed, Aug 7, 2013 at 2:55 PM, <gri@golang.org> wrote:

>
> https://codereview.appspot.**com/12300043/diff/67001/src/**
>
cmd/api/goapi.go<https://codereview.appspot.com/12300043/diff/67001/src/cmd/api/goapi.go>
> File src/cmd/api/goapi.go (right):
>
> https://codereview.appspot.**com/12300043/diff/67001/src/**
>
cmd/api/goapi.go#newcode643<https://codereview.appspot.com/12300043/diff/67001/src/cmd/api/goapi.go#newcode643>
> src/cmd/api/goapi.go:643: case *types.TypeName:
> On 2013/08/07 21:47:52, bradfitz wrote:
>
>> move this to a new emitType method?  it's big enough.
>>
>
> Done.
>
>
https://codereview.appspot.**com/12300043/<https://codereview.appspot.com/123...
>

[gri, 2013-08-08 00:54:07]

where are those files? I don't see a api/go1.txt in cmd/api


On Wed, Aug 7, 2013 at 5:52 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> Robert,
>
> You also need to update api/go1.txt (and go1.1.txt if needed) in this CL
> as well, correcting its old mistakes.
>
>
>
> On Wed, Aug 7, 2013 at 2:55 PM, <gri@golang.org> wrote:
>
>>
>> https://codereview.appspot.**com/12300043/diff/67001/src/**
>>
cmd/api/goapi.go<https://codereview.appspot.com/12300043/diff/67001/src/cmd/api/goapi.go>
>> File src/cmd/api/goapi.go (right):
>>
>> https://codereview.appspot.**com/12300043/diff/67001/src/**
>>
cmd/api/goapi.go#newcode643<https://codereview.appspot.com/12300043/diff/67001/src/cmd/api/goapi.go#newcode643>
>> src/cmd/api/goapi.go:643: case *types.TypeName:
>> On 2013/08/07 21:47:52, bradfitz wrote:
>>
>>> move this to a new emitType method?  it's big enough.
>>>
>>
>> Done.
>>
>>
https://codereview.appspot.**com/12300043/<https://codereview.appspot.com/123...
>>
>
>

[bradfitz, 2013-08-08 00:55:15]

$GOROOT/api/


On Wed, Aug 7, 2013 at 5:54 PM, Robert Griesemer <gri@golang.org> wrote:

> where are those files? I don't see a api/go1.txt in cmd/api
>
>
> On Wed, Aug 7, 2013 at 5:52 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:
>
>> Robert,
>>
>> You also need to update api/go1.txt (and go1.1.txt if needed) in this CL
>> as well, correcting its old mistakes.
>>
>>
>>
>> On Wed, Aug 7, 2013 at 2:55 PM, <gri@golang.org> wrote:
>>
>>>
>>> https://codereview.appspot.**com/12300043/diff/67001/src/**
>>>
cmd/api/goapi.go<https://codereview.appspot.com/12300043/diff/67001/src/cmd/api/goapi.go>
>>> File src/cmd/api/goapi.go (right):
>>>
>>> https://codereview.appspot.**com/12300043/diff/67001/src/**
>>>
cmd/api/goapi.go#newcode643<https://codereview.appspot.com/12300043/diff/67001/src/cmd/api/goapi.go#newcode643>
>>> src/cmd/api/goapi.go:643: case *types.TypeName:
>>> On 2013/08/07 21:47:52, bradfitz wrote:
>>>
>>>> move this to a new emitType method?  it's big enough.
>>>>
>>>
>>> Done.
>>>
>>>
https://codereview.appspot.**com/12300043/<https://codereview.appspot.com/123...
>>>
>>
>>
>

[gri, 2013-08-08 20:49:45]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-08-08 21:10:32]

LGTM



On Thu, Aug 8, 2013 at 1:49 PM, <gri@golang.org> wrote:

> Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
https://codereview.appspot.**com/12300043/<https://codereview.appspot.com/123...
>

[gri, 2013-08-08 21:11:04]

*** Submitted as https://code.google.com/p/go/source/detail?r=f5b37c93e4c5 ***

cmd/api: rewrite using go/types

- adjusted test files so that they actually type-check
- adjusted go1.txt, go1.1.txt, next.txt
- to run, provide build tag: api_tool

Fixes issue 4538.

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/12300043