Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Delta Between Two Patch Sets: api/go1.1.txt

Issue 12300043: code review 12300043: cmd/api: rewrite using go/types (Closed)
Left Patch Set: diff -r 564e8c77a065 https://code.google.com/p/go Created 11 years, 7 months ago
Right Patch Set: diff -r f53cee5f15de https://code.google.com/p/go Created 11 years, 7 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « api/go1.txt ('k') | api/next.txt » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 pkg archive/tar, const TypeGNULongLink ideal-char 1 pkg archive/tar, const TypeGNULongLink ideal-char
2 pkg archive/tar, const TypeGNULongName ideal-char 2 pkg archive/tar, const TypeGNULongName ideal-char
3 pkg archive/tar, func FileInfoHeader(os.FileInfo, string) (*Header, error) 3 pkg archive/tar, func FileInfoHeader(os.FileInfo, string) (*Header, error)
4 pkg archive/tar, method (*Header) FileInfo() os.FileInfo 4 pkg archive/tar, method (*Header) FileInfo() os.FileInfo
5 pkg archive/zip, type FileHeader struct, CompressedSize64 uint64 5 pkg archive/zip, type FileHeader struct, CompressedSize64 uint64
6 pkg archive/zip, type FileHeader struct, UncompressedSize64 uint64 6 pkg archive/zip, type FileHeader struct, UncompressedSize64 uint64
7 pkg bufio, const MaxScanTokenSize ideal-int 7 pkg bufio, const MaxScanTokenSize ideal-int
8 pkg bufio, func NewScanner(io.Reader) *Scanner 8 pkg bufio, func NewScanner(io.Reader) *Scanner
9 pkg bufio, func ScanBytes([]uint8, bool) (int, []uint8, error) 9 pkg bufio, func ScanBytes([]uint8, bool) (int, []uint8, error)
10 pkg bufio, func ScanLines([]uint8, bool) (int, []uint8, error) 10 pkg bufio, func ScanLines([]uint8, bool) (int, []uint8, error)
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 pkg debug/pe, type Symbol struct, Value uint32 85 pkg debug/pe, type Symbol struct, Value uint32
86 pkg encoding/csv, method (*Writer) Error() error 86 pkg encoding/csv, method (*Writer) Error() error
87 pkg encoding/json, method (*Decoder) Buffered() io.Reader 87 pkg encoding/json, method (*Decoder) Buffered() io.Reader
88 pkg encoding/json, method (*Decoder) UseNumber() 88 pkg encoding/json, method (*Decoder) UseNumber()
89 pkg encoding/json, method (Number) Float64() (float64, error) 89 pkg encoding/json, method (Number) Float64() (float64, error)
90 pkg encoding/json, method (Number) Int64() (int64, error) 90 pkg encoding/json, method (Number) Int64() (int64, error)
91 pkg encoding/json, method (Number) String() string 91 pkg encoding/json, method (Number) String() string
92 pkg encoding/json, type Number string 92 pkg encoding/json, type Number string
93 pkg encoding/xml, func EscapeText(io.Writer, []uint8) error 93 pkg encoding/xml, func EscapeText(io.Writer, []uint8) error
94 pkg encoding/xml, method (*Encoder) Indent(string, string) 94 pkg encoding/xml, method (*Encoder) Indent(string, string)
95 pkg encoding/xml, method (Encoder) ReadFrom(io.Reader) (int64, error)
95 pkg encoding/xml, type Decoder struct, DefaultSpace string 96 pkg encoding/xml, type Decoder struct, DefaultSpace string
96 pkg go/ast, func NewCommentMap(*token.FileSet, Node, []*CommentGroup) CommentMap 97 pkg go/ast, func NewCommentMap(*token.FileSet, Node, []*CommentGroup) CommentMap
97 pkg go/ast, method (CommentMap) Comments() []*CommentGroup 98 pkg go/ast, method (CommentMap) Comments() []*CommentGroup
98 pkg go/ast, method (CommentMap) Filter(Node) CommentMap 99 pkg go/ast, method (CommentMap) Filter(Node) CommentMap
99 pkg go/ast, method (CommentMap) String() string 100 pkg go/ast, method (CommentMap) String() string
100 pkg go/ast, method (CommentMap) Update(Node, Node) Node 101 pkg go/ast, method (CommentMap) Update(Node, Node) Node
101 pkg go/ast, type ChanType struct, Arrow token.Pos 102 pkg go/ast, type ChanType struct, Arrow token.Pos
102 pkg go/ast, type CommentMap map[Node][]*CommentGroup 103 pkg go/ast, type CommentMap map[Node][]*CommentGroup
103 pkg go/build, type Context struct, InstallSuffix string 104 pkg go/build, type Context struct, InstallSuffix string
104 pkg go/build, type Context struct, ReleaseTags []string 105 pkg go/build, type Context struct, ReleaseTags []string
(...skipping 1588 matching lines...) Expand 10 before | Expand all | Expand 10 after
1693 pkg testing, method (*B) Skipped() bool 1694 pkg testing, method (*B) Skipped() bool
1694 pkg testing, method (*T) Skip(...interface{}) 1695 pkg testing, method (*T) Skip(...interface{})
1695 pkg testing, method (*T) SkipNow() 1696 pkg testing, method (*T) SkipNow()
1696 pkg testing, method (*T) Skipf(string, ...interface{}) 1697 pkg testing, method (*T) Skipf(string, ...interface{})
1697 pkg testing, method (*T) Skipped() bool 1698 pkg testing, method (*T) Skipped() bool
1698 pkg testing, method (BenchmarkResult) AllocedBytesPerOp() int64 1699 pkg testing, method (BenchmarkResult) AllocedBytesPerOp() int64
1699 pkg testing, method (BenchmarkResult) AllocsPerOp() int64 1700 pkg testing, method (BenchmarkResult) AllocsPerOp() int64
1700 pkg testing, method (BenchmarkResult) MemString() string 1701 pkg testing, method (BenchmarkResult) MemString() string
1701 pkg testing, type BenchmarkResult struct, MemAllocs uint64 1702 pkg testing, type BenchmarkResult struct, MemAllocs uint64
1702 pkg testing, type BenchmarkResult struct, MemBytes uint64 1703 pkg testing, type BenchmarkResult struct, MemBytes uint64
1704 pkg text/template, method (Template) ErrorContext(parse.Node) (string, string)
1703 pkg text/template/parse, const NodeChain NodeType 1705 pkg text/template/parse, const NodeChain NodeType
1704 pkg text/template/parse, const NodeNil NodeType 1706 pkg text/template/parse, const NodeNil NodeType
1705 pkg text/template/parse, method (*ChainNode) Add(string) 1707 pkg text/template/parse, method (*ChainNode) Add(string)
1706 pkg text/template/parse, method (*ChainNode) Copy() Node 1708 pkg text/template/parse, method (*ChainNode) Copy() Node
1707 pkg text/template/parse, method (*ChainNode) String() string 1709 pkg text/template/parse, method (*ChainNode) String() string
1708 pkg text/template/parse, method (*IdentifierNode) SetPos(Pos) *IdentifierNode 1710 pkg text/template/parse, method (*IdentifierNode) SetPos(Pos) *IdentifierNode
1709 pkg text/template/parse, method (*NilNode) Copy() Node 1711 pkg text/template/parse, method (*NilNode) Copy() Node
1710 pkg text/template/parse, method (*NilNode) String() string 1712 pkg text/template/parse, method (*NilNode) String() string
1711 pkg text/template/parse, method (*NilNode) Type() NodeType 1713 pkg text/template/parse, method (*NilNode) Type() NodeType
1712 pkg text/template/parse, method (*Tree) ErrorContext(Node) (string, string) 1714 pkg text/template/parse, method (*Tree) ErrorContext(Node) (string, string)
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
1764 pkg time, method (Time) YearDay() int 1766 pkg time, method (Time) YearDay() int
1765 pkg unicode, type RangeTable struct, LatinOffset int 1767 pkg unicode, type RangeTable struct, LatinOffset int
1766 pkg unicode, var Chakma *RangeTable 1768 pkg unicode, var Chakma *RangeTable
1767 pkg unicode, var Meroitic_Cursive *RangeTable 1769 pkg unicode, var Meroitic_Cursive *RangeTable
1768 pkg unicode, var Meroitic_Hieroglyphs *RangeTable 1770 pkg unicode, var Meroitic_Hieroglyphs *RangeTable
1769 pkg unicode, var Miao *RangeTable 1771 pkg unicode, var Miao *RangeTable
1770 pkg unicode, var Sharada *RangeTable 1772 pkg unicode, var Sharada *RangeTable
1771 pkg unicode, var Sora_Sompeng *RangeTable 1773 pkg unicode, var Sora_Sompeng *RangeTable
1772 pkg unicode, var Takri *RangeTable 1774 pkg unicode, var Takri *RangeTable
1773 pkg unicode/utf8, func ValidRune(int32) bool 1775 pkg unicode/utf8, func ValidRune(int32) bool
LEFTRIGHT
« api/go1.txt ('k') | api/next.txt » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b