Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8881)

Issue 11996043: code review 11996043: [release-branch.go1.1] syscall: prlimit argument error ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by adg
Modified:
9 years, 4 months ago
Reviewers:
dfc
CC:
golang-dev, dfc
Visibility:
Public.

Description

[release-branch.go1.1] syscall: prlimit argument error for Getrlimit and Setrlimit on Linux 32-bit ««« CL 11803043 / ba52f6399462 syscall: prlimit argument error for Getrlimit and Setrlimit on Linux 32-bit The rlimit arguments for prlimit are reversed for linux 32-bit (386 and arm). Getrlimit becomes Setrlimit and vice versa. Fixes issue 5949. R=iant, mikioh.mikioh, rsc CC=golang-dev https://codereview.appspot.com/11803043 Committer: Russ Cox <rsc@golang.org> »»» Update issue 5928

Patch Set 1 #

Patch Set 2 : diff -r 4e2d025187c6 https://code.google.com/p/go #

Patch Set 3 : diff -r 4e2d025187c6 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
A src/pkg/syscall/rlimit_linux_test.go View 1 1 chunk +41 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_linux_386.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_linux_arm.go View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 4 months ago (2013-07-29 00:03:01 UTC) #1
dfc
LGTM. This one needs to be called out in the release notes. On Mon, Jul ...
9 years, 4 months ago (2013-07-29 00:19:58 UTC) #2
adg
9 years, 4 months ago (2013-07-29 00:34:57 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=55ac276af5a7 ***

[release-branch.go1.1] syscall: prlimit argument error for Getrlimit and
Setrlimit on Linux 32-bit

««« CL 11803043 / ba52f6399462
syscall: prlimit argument error for Getrlimit and Setrlimit on Linux 32-bit

The rlimit arguments for prlimit are reversed for linux 32-bit (386 and arm).
Getrlimit becomes Setrlimit and vice versa.
Fixes issue 5949.

R=iant, mikioh.mikioh, rsc
CC=golang-dev
https://codereview.appspot.com/11803043

Committer: Russ Cox <rsc@golang.org>
»»»

Update issue 5928

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11996043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b