Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 11803043: code review 11803043: syscall: prlimit argument error for Getrlimit and Setrl...

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by peterGo
Modified:
3 years, 8 months ago
Reviewers:
rsc
CC:
iant, mikio, rsc, golang-dev
Visibility:
Public.

Description

syscall: prlimit argument error for Getrlimit and Setrlimit on Linux 32-bit The rlimit arguments for prlimit are reversed for linux 32-bit (386 and arm). Getrlimit becomes Setrlimit and vice versa. Fixes issue 5949.

Patch Set 1 #

Patch Set 2 : diff -r c8e02f321281 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r c8e02f321281 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r c8e02f321281 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 3ffbc06b4874 https://go.googlecode.com/hg/ #

Total comments: 8

Patch Set 6 : diff -r 40bbcafc819c https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 40bbcafc819c https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r 40bbcafc819c https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 9 : diff -r 40bbcafc819c https://go.googlecode.com/hg/ #

Patch Set 10 : diff -r 40bbcafc819c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
A src/pkg/syscall/rlimit_linux_test.go View 1 2 3 4 5 6 7 8 1 chunk +41 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_linux_386.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_linux_arm.go View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10
peterGo
Hello iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
3 years, 8 months ago (2013-07-25 01:09:53 UTC) #1
peterGo
Hello iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
3 years, 8 months ago (2013-07-25 02:14:23 UTC) #2
iant
https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_linux_32_test.go File src/pkg/syscall/syscall_linux_32_test.go (right): https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_linux_32_test.go#newcode6 src/pkg/syscall/syscall_linux_32_test.go:6: // +build 386 arm Why not run the test ...
3 years, 8 months ago (2013-07-25 04:21:41 UTC) #3
peterGo
https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_linux_32_test.go File src/pkg/syscall/syscall_linux_32_test.go (right): https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_linux_32_test.go#newcode6 src/pkg/syscall/syscall_linux_32_test.go:6: // +build 386 arm On 2013/07/25 04:21:42, iant wrote: ...
3 years, 8 months ago (2013-07-25 06:50:27 UTC) #4
peterGo
Hello iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
3 years, 8 months ago (2013-07-25 06:51:21 UTC) #5
mikio
https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_linux_test.go File src/pkg/syscall/rlimit_linux_test.go (right): https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_linux_test.go#newcode20 src/pkg/syscall/rlimit_linux_test.go:20: return you can drop return just after t.Fatalf https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_linux_test.go#newcode37 ...
3 years, 8 months ago (2013-07-25 09:59:17 UTC) #6
peterGo
https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_linux_test.go File src/pkg/syscall/rlimit_linux_test.go (right): https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_linux_test.go#newcode20 src/pkg/syscall/rlimit_linux_test.go:20: return On 2013/07/25 09:59:18, mikio wrote: > you can ...
3 years, 8 months ago (2013-07-25 11:42:28 UTC) #7
peterGo
Hello iant@golang.org, mikioh.mikioh@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
3 years, 8 months ago (2013-07-25 11:43:08 UTC) #8
rsc
LGTM
3 years, 8 months ago (2013-07-25 13:55:44 UTC) #9
rsc
3 years, 8 months ago (2013-07-25 13:56:12 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=ba52f6399462 ***

syscall: prlimit argument error for Getrlimit and Setrlimit on Linux 32-bit

The rlimit arguments for prlimit are reversed for linux 32-bit (386 and arm).
Getrlimit becomes Setrlimit and vice versa.
Fixes issue 5949.

R=iant, mikioh.mikioh, rsc
CC=golang-dev
https://codereview.appspot.com/11803043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted