code review 11803043: syscall: prlimit argument error for Getrlimit and Setrl...

syscall: prlimit argument error for Getrlimit and Setrlimit on Linux 32-bit

The rlimit arguments for prlimit are reversed for linux 32-bit (386 and arm).
Getrlimit becomes Setrlimit and vice versa.
Fixes issue 5949.

[peterGo, 2013-07-25 01:09:53]

Hello iant@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[peterGo, 2013-07-25 02:14:23]

Hello iant@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[iant, 2013-07-25 04:21:41]

https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_li...
File src/pkg/syscall/syscall_linux_32_test.go (right):

https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_li...
src/pkg/syscall/syscall_linux_32_test.go:6: // +build 386 arm
Why not run the test on every linux platform?

If you name the file rlimit_linux_test.go you won't need to use any +build tags.

https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_li...
src/pkg/syscall/syscall_linux_32_test.go:16: var rlimit, zeroRlimit
syscall.Rlimit
s/zeroRlimit/zero/

https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_li...
src/pkg/syscall/syscall_linux_32_test.go:25: setRlimit := rlimit
s/setRlimit/set/

https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_li...
src/pkg/syscall/syscall_linux_32_test.go:31: var getRlimit syscall.Rlimit
s/getRlimit/get/

[peterGo, 2013-07-25 06:50:27]

https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_li...
File src/pkg/syscall/syscall_linux_32_test.go (right):

https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_li...
src/pkg/syscall/syscall_linux_32_test.go:6: // +build 386 arm
On 2013/07/25 04:21:42, iant wrote:
> Why not run the test on every linux platform?
> 
> If you name the file rlimit_linux_test.go you won't need to use any +build
tags.

Done.

https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_li...
src/pkg/syscall/syscall_linux_32_test.go:16: var rlimit, zeroRlimit
syscall.Rlimit
On 2013/07/25 04:21:42, iant wrote:
> s/zeroRlimit/zero/

Done.

https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_li...
src/pkg/syscall/syscall_linux_32_test.go:25: setRlimit := rlimit
On 2013/07/25 04:21:42, iant wrote:
> s/setRlimit/set/

Done.

https://codereview.appspot.com/11803043/diff/14001/src/pkg/syscall/syscall_li...
src/pkg/syscall/syscall_linux_32_test.go:31: var getRlimit syscall.Rlimit
On 2013/07/25 04:21:42, iant wrote:
> s/getRlimit/get/

Done.

[peterGo, 2013-07-25 06:51:21]

Hello iant@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[mikio, 2013-07-25 09:59:17]

https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_lin...
File src/pkg/syscall/rlimit_linux_test.go (right):

https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_lin...
src/pkg/syscall/rlimit_linux_test.go:20: return
you can drop return just after t.Fatalf

https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_lin...
src/pkg/syscall/rlimit_linux_test.go:37: return
ditto

[peterGo, 2013-07-25 11:42:28]

https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_lin...
File src/pkg/syscall/rlimit_linux_test.go (right):

https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_lin...
src/pkg/syscall/rlimit_linux_test.go:20: return
On 2013/07/25 09:59:18, mikio wrote:
> you can drop return just after t.Fatalf

Done.

https://codereview.appspot.com/11803043/diff/21001/src/pkg/syscall/rlimit_lin...
src/pkg/syscall/rlimit_linux_test.go:37: return
On 2013/07/25 09:59:18, mikio wrote:
> ditto

Done.

[peterGo, 2013-07-25 11:43:08]

Hello iant@golang.org, mikioh.mikioh@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-07-25 13:55:44]

LGTM

[rsc, 2013-07-25 13:56:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=ba52f6399462 ***

syscall: prlimit argument error for Getrlimit and Setrlimit on Linux 32-bit

The rlimit arguments for prlimit are reversed for linux 32-bit (386 and arm).
Getrlimit becomes Setrlimit and vice versa.
Fixes issue 5949.

R=iant, mikioh.mikioh, rsc
CC=golang-dev
https://codereview.appspot.com/11803043

Committer: Russ Cox <rsc@golang.org>