Ghost and inspector settings changes

Ghost and inspector settings changes

Working towards matching the ghost settings changes
to the mockup and normalizing the inspector and ghost
settings pages.

https://code.launchpad.net/~hatch/juju-gui/ghost-ui-mods/+merge/176991

(do not edit description out of merge proposal)

[jeff.pihach, 2013-07-25 16:33:17]

Please take a look.

[j.c.sackett, 2013-07-25 16:59:02]

LGTM, though I have one comment.

https://codereview.appspot.com/11843043/diff/1/app/templates/serviceOverview....
File app/templates/serviceOverview.handlebars (right):

https://codereview.appspot.com/11843043/diff/1/app/templates/serviceOverview....
app/templates/serviceOverview.handlebars:6: <svg class="statusbar"
data-bind="aggregated_status" height="18"></svg>
Does the comment mean we can't set this as a CSS rule on .svg.statusbar? It
*must* be in the DOM?

[jeff.pihach, 2013-07-25 17:15:32]

Thanks for the review!

https://codereview.appspot.com/11843043/diff/1/app/templates/serviceOverview....
File app/templates/serviceOverview.handlebars (right):

https://codereview.appspot.com/11843043/diff/1/app/templates/serviceOverview....
app/templates/serviceOverview.handlebars:6: <svg class="statusbar"
data-bind="aggregated_status" height="18"></svg>
No it can be done in CSS however this element is used in multiple places in the
app so Ben and I figured the best place to put it where it wouldn't accidentally
get overwritten was right in the DOM.

[jeff.pihach, 2013-07-25 18:01:13]

Please take a look.

[gary.poster, 2013-07-25 18:38:21]

LGTM with given changes.  Thank you!

https://codereview.appspot.com/11843043/diff/1/app/templates/ghost-config-vie...
File app/templates/ghost-config-viewlet.handlebars (right):

https://codereview.appspot.com/11843043/diff/1/app/templates/ghost-config-vie...
app/templates/ghost-config-viewlet.handlebars:2: {{#unless isSubordinate}}
per my IRC comments, this needs to be is_subordinate.

https://codereview.appspot.com/11843043/diff/1/app/templates/ghost-config-wra...
File app/templates/ghost-config-wrapper.handlebars (left):

https://codereview.appspot.com/11843043/diff/1/app/templates/ghost-config-wra...
app/templates/ghost-config-wrapper.handlebars:9: {{#unless isSubordinate}}
Because you removed this, you should also remove the isSubordinate definition
from environment.js

=== modified file 'app/views/environment.js'
--- app/views/environment.js	2013-07-24 21:46:12 +0000
+++ app/views/environment.js	2013-07-25 18:30:24 +0000
@@ -240,8 +240,7 @@
               // the configuration for the view manager template
               templateConfig: {
                 packageName: model.get('package_name'),
-                id: model.get('id'),
-                isSubordinate: model.get('is_subordinate')
+                id: model.get('id')
               }
             }
           };

https://codereview.appspot.com/11843043/diff/1/app/templates/serviceOverview....
File app/templates/serviceOverview.handlebars (right):

https://codereview.appspot.com/11843043/diff/1/app/templates/serviceOverview....
app/templates/serviceOverview.handlebars:6: <svg class="statusbar"
data-bind="aggregated_status" height="18"></svg>
On 2013/07/25 17:15:32, jeff.pihach wrote:
> No it can be done in CSS however this element is used in multiple places in
the
> app so Ben and I figured the best place to put it where it wouldn't
accidentally
> get overwritten was right in the DOM.

Maybe add this explanation to your comment?

[jeff.pihach, 2013-07-25 19:18:41]

Please take a look.

[jeff.pihach, 2013-07-25 19:26:38]

*** Submitted:

Ghost and inspector settings changes

Working towards matching the ghost settings changes
to the mockup and normalizing the inspector and ghost
settings pages.

R=j.c.sackett, gary.poster
CC=
https://codereview.appspot.com/11843043