app/templates/serviceOverview.handlebars - Issue 11843043: Ghost and inspector settings changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: app/templates/serviceOverview.handlebars

Issue 11843043: Ghost and inspector settings changes

Patch Set: Created 11 years, 8 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <div class="content">	1 <div class="content">

2 <div class="notifications"></div>	2 <div class="notifications"></div>

3 <svg class="statusbar" data-bind="aggregated_status"></svg>	3 <!-- without setting the height of the svg element here it defaults

	4 to 100% of the available space causing an undesirable flash of

	5 incorrectly calculated height -->

	6 <svg class="statusbar" data-bind="aggregated_status" height="18"></svg>
	j.c.sackett 2013/07/25 16:59:02 Does the comment mean we can't set this as a CSS r Does the comment mean we can't set this as a CSS rule on .svg.statusbar? It must be in the DOM? jeff.pihach 2013/07/25 17:15:32 No it can be done in CSS however this element is u No it can be done in CSS however this element is used in multiple places in the app so Ben and I figured the best place to put it where it wouldn't accidentally get overwritten was right in the DOM. gary.poster 2013/07/25 18:38:21 Maybe add this explanation to your comment? Show quoted text On 2013/07/25 17:15:32, jeff.pihach wrote: > No it can be done in CSS however this element is used in multiple places in the > app so Ben and I figured the best place to put it where it wouldn't accidentally > get overwritten was right in the DOM. Maybe add this explanation to your comment?
4 </div>	7 </div>

5 <h3>Scale units</h3>	8 <h3>Scale units</h3>

6 <div class="content">	9 <div class="content">

7 <input type="text" class="num-units-control" data-bind="unit_count" />	10 <input type="text" class="num-units-control" data-bind="unit_count" />

8 </div>	11 </div>

9 <h3>Units</h3>	12 <h3>Units</h3>

10 <ul class="overview-unit-list" data-bind="units">	13 <ul class="overview-unit-list" data-bind="units">

11 </ul>	14 </ul>

OLD	NEW

« app/templates/ghost-config-wrapper.handlebars ('K') | « app/templates/ghost-config-wrapper.handlebars ('k') | app/views/inspector.js » ('j') | no next file with comments »