code review 118000043: test: add test for confusion with dot imports

test: add test for confusion with dot imports

The gccgo compiler would fail this test.  The fix for gccgo is
http://codereview.appspot.com/116960043 .

[iant, 2014-07-20 14:50:00]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2014-07-20 16:55:56]

LGTM
 On Jul 20, 2014 9:50 AM, <iant@golang.org> wrote:

> Reviewers: golang-codereviews,
>
> Message:
> Hello golang-codereviews@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> test: add test for confusion with dot imports
>
> The gccgo compiler would fail this test.  The fix for gccgo is
> http://codereview.appspot.com/116960043 .
>
> Please review this at https://codereview.appspot.com/118000043/
>
> Affected files (+28, -0 lines):
>   A test/fixedbugs/bug488.go
>   A test/fixedbugs/bug488.dir/a.go
>   A test/fixedbugs/bug488.dir/b.go
>
>
> Index: test/fixedbugs/bug488.dir/a.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/test/fixedbugs/bug488.dir/a.go
> @@ -0,0 +1,7 @@
> +// Copyright 2014 The Go Authors.  All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package a
> +
> +var p2 = Printf                // ERROR "undefined"
> Index: test/fixedbugs/bug488.dir/b.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/test/fixedbugs/bug488.dir/b.go
> @@ -0,0 +1,9 @@
> +// Copyright 2014 The Go Authors.  All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +package a
> +
> +import . "fmt"
> +
> +var p1 = Print
> Index: test/fixedbugs/bug488.go
> ===================================================================
> new file mode 100644
> --- /dev/null
> +++ b/test/fixedbugs/bug488.go
> @@ -0,0 +1,12 @@
> +// errorcheckdir
> +
> +// Copyright 2014 The Go Authors.  All rights reserved.
> +// Use of this source code is governed by a BSD-style
> +// license that can be found in the LICENSE file.
> +
> +// The gccgo compiler had a bug: if one file in a package did a dot
> +// import, then an earlier file in the package would incorrectly
> +// resolve to the imported names rather than reporting undefined
> +// errors.
> +
> +package ignored
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[iant, 2014-07-20 17:28:56]

*** Submitted as https://code.google.com/p/go/source/detail?r=7ef3da0152de ***

test: add test for confusion with dot imports

The gccgo compiler would fail this test.  The fix for gccgo is
http://codereview.appspot.com/116960043 .

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/118000043