Issue 116960043: code review 116960043: compiler: Don't let dot-import names match names from p...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 116960043: code review 116960043: compiler: Don't let dot-import names match names from p... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by iant

Modified:
10 years, 4 months ago

Reviewers:

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

compiler: Don't let dot-import names match names from previous files. The test case for this will be bug488.go in the main repository: https://codereview.appspot.com/118000043 .

Patch Set 1 #

Patch Set 2 : diff -r f75db1811715 https://gofrontend.googlecode.com/hg/ #

Patch Set 3 : diff -r 0e313c250b05 https://gofrontend.googlecode.com/hg/ #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -11 lines)			Patch
M	go/gogo.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	go/gogo.cc	View	2 chunks	+25 lines, -4 lines	0 comments	Download
M	go/import.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	go/unsafe.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

iant

Hello iant (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://gofrontend.googlecode.com/hg/

10 years, 4 months ago (2014-07-20 15:12:11 UTC) #1

iant

10 years, 4 months ago (2014-07-20 15:12:15 UTC) #2

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=cc0233176c9b ***

compiler: Don't let dot-import names match names from previous files.

The test case for this will be bug488.go in the main
repository: https://codereview.appspot.com/118000043 .

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/116960043

Expand All Messages | Collapse All Messages