Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(331)

Issue 11517043: Initial pass at charm details in inspector

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by matthew.scott
Modified:
7 years, 3 months ago
Reviewers:
benjamin.saller, jeff.pihach, mp+175585
Visibility:
Public.

Description

Initial pass at charm details in inspector This adds the charm details to the inspector, pulling the data from the charm store when possible. It uses the existing browser code to display that information. https://code.launchpad.net/~makyo/juju-gui/charm-details-inspector/+merge/175585 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 14

Patch Set 2 : Initial pass at charm details in inspector #

Patch Set 3 : Initial pass at charm details in inspector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -86 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/charm.js View 1 chunk +11 lines, -0 lines 0 comments Download
M app/modules-debug.js View 1 chunk +5 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 2 chunks +53 lines, -49 lines 0 comments Download
M app/subapps/browser/views/charm.js View 8 chunks +45 lines, -16 lines 0 comments Download
M app/templates/left-breakout-panel.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/templates/serviceOverview.handlebars View 1 chunk +1 line, -1 line 0 comments Download
M app/views/environment.js View 2 chunks +23 lines, -14 lines 0 comments Download
M app/views/service.js View 1 6 chunks +25 lines, -4 lines 0 comments Download
M app/views/view-container.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
A app/views/viewlets/charm-details.js View 1 1 chunk +73 lines, -0 lines 0 comments Download
M test/index.html View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_browser_charm_details.js View 4 chunks +18 lines, -0 lines 0 comments Download
A test/test_inspector_charm.js View 1 chunk +88 lines, -0 lines 0 comments Download
M test/test_view_container.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
matthew.scott
Please take a look.
7 years, 3 months ago (2013-07-18 14:27:35 UTC) #1
benjamin.saller
LGTM w/o qa, thanks. I think the viewlet separation is moving the right direction https://codereview.appspot.com/11517043/diff/1/app/subapps/browser/templates/browser_charm.handlebars ...
7 years, 3 months ago (2013-07-18 14:54:19 UTC) #2
jeff.pihach
LGTM with comments below https://codereview.appspot.com/11517043/diff/1/app/views/environment.js File app/views/environment.js (right): https://codereview.appspot.com/11517043/diff/1/app/views/environment.js#newcode184 app/views/environment.js:184: 'a[data-unit]': { click: 'showUnitDetails'}, Can ...
7 years, 3 months ago (2013-07-18 15:17:24 UTC) #3
rharding
Comments below. Updated branch on the way. https://codereview.appspot.com/11517043/diff/1/app/templates/serviceOverview.handlebars File app/templates/serviceOverview.handlebars (right): https://codereview.appspot.com/11517043/diff/1/app/templates/serviceOverview.handlebars#newcode6 app/templates/serviceOverview.handlebars:6: <span data-bind="charm" ...
7 years, 3 months ago (2013-07-18 15:28:34 UTC) #4
matthew.scott
Please take a look.
7 years, 3 months ago (2013-07-18 15:32:27 UTC) #5
matthew.scott
7 years, 3 months ago (2013-07-18 15:47:20 UTC) #6
*** Submitted:

Initial pass at charm details in inspector

This adds the charm details to the inspector, pulling the data from the charm
store when possible.  It uses the existing browser code to display that
information.

R=benjamin.saller, jeff.pihach, rharding
CC=
https://codereview.appspot.com/11517043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b