Initial pass at charm details in inspector

Initial pass at charm details in inspector

This adds the charm details to the inspector, pulling the data from the charm store when possible.  It uses the existing browser code to display that information.

https://code.launchpad.net/~makyo/juju-gui/charm-details-inspector/+merge/175585

(do not edit description out of merge proposal)

[matthew.scott, 2013-07-18 14:27:35]

Please take a look.

[benjamin.saller, 2013-07-18 14:54:19]

LGTM w/o qa, thanks. I think the viewlet separation is moving the right
direction

https://codereview.appspot.com/11517043/diff/1/app/subapps/browser/templates/...
File app/subapps/browser/templates/browser_charm.handlebars (right):

https://codereview.appspot.com/11517043/diff/1/app/subapps/browser/templates/...
app/subapps/browser/templates/browser_charm.handlebars:3: {{#unless
forInspector}}
Ha

https://codereview.appspot.com/11517043/diff/1/app/templates/serviceOverview....
File app/templates/serviceOverview.handlebars (right):

https://codereview.appspot.com/11517043/diff/1/app/templates/serviceOverview....
app/templates/serviceOverview.handlebars:6: <span data-bind="charm"
class="charmURL" data-charmid="{{charm}}"></span>
No camels?

https://codereview.appspot.com/11517043/diff/1/app/views/environment.js
File app/views/environment.js (left):

https://codereview.appspot.com/11517043/diff/1/app/views/environment.js#oldco...
app/views/environment.js:182: viewletEvents: {
Thanks for the cleanup

https://codereview.appspot.com/11517043/diff/1/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/11517043/diff/1/app/views/service.js#newcode43
app/views/service.js:43: IMPORTED_VIEWLET_CONFIGS.push(viewletNS.charmDetails);
This pattern needs to be documented. Its a good step but people won't see to use
it or that placement within the code is important.

I see the note at the bottom, but it might make sense here

https://codereview.appspot.com/11517043/diff/1/app/views/view-container.js
File app/views/view-container.js (right):

https://codereview.appspot.com/11517043/diff/1/app/views/view-container.js#ne...
app/views/view-container.js:332: console.warn('Attempted to load a viewlet that
does nto exist');
'not' exist

https://codereview.appspot.com/11517043/diff/1/app/views/viewlets/charm-detai...
File app/views/viewlets/charm-details.js (right):

https://codereview.appspot.com/11517043/diff/1/app/views/viewlets/charm-detai...
app/views/viewlets/charm-details.js:53: 'failure': function(data, request) {
request isn't used

[jeff.pihach, 2013-07-18 15:17:24]

LGTM with comments below

https://codereview.appspot.com/11517043/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/11517043/diff/1/app/views/environment.js#newco...
app/views/environment.js:184: 'a[data-unit]': { click: 'showUnitDetails'},
Can you sort these by viewlet so that we can see which events go with which
viewlets.

https://codereview.appspot.com/11517043/diff/1/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/11517043/diff/1/app/views/service.js#newcode21
app/views/service.js:21: var IMPORTED_VIEWLET_CONFIGS = [];
if (!IMPORTED_VIEWLET_CONFIGS) {
  var IMPORTED_VIEWLET_CONFIGS = [];
}

https://codereview.appspot.com/11517043/diff/1/app/views/service.js#newcode43
app/views/service.js:43: IMPORTED_VIEWLET_CONFIGS.push(viewletNS.charmDetails);
I think that this is adding an unnecessary step when we could simply be looping
over the viewletNS namespace following the same pattern that we use everywhere
else in the app.

https://codereview.appspot.com/11517043/diff/1/app/views/service.js#newcode2010
app/views/service.js:2010: IMPORTED_VIEWLET_CONFIGS.forEach(function(config) {
see comment above about viewletNS namespace loop

[rharding, 2013-07-18 15:28:34]

Comments below. Updated branch on the way.

https://codereview.appspot.com/11517043/diff/1/app/templates/serviceOverview....
File app/templates/serviceOverview.handlebars (right):

https://codereview.appspot.com/11517043/diff/1/app/templates/serviceOverview....
app/templates/serviceOverview.handlebars:6: <span data-bind="charm"
class="charmURL" data-charmid="{{charm}}"></span>
On 2013/07/18 14:54:20, benjamin.saller wrote:
> No camels?

not in an html attr name. :)

https://codereview.appspot.com/11517043/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/11517043/diff/1/app/views/environment.js#newco...
app/views/environment.js:184: 'a[data-unit]': { click: 'showUnitDetails'},
On 2013/07/18 15:17:24, jeff.pihach wrote:
> Can you sort these by viewlet so that we can see which events go with which
> viewlets.

Ugh, if they should be namespaced by the viewlet can we agree that this should
be a nested object of viewletName: { events...} ?

https://codereview.appspot.com/11517043/diff/1/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/11517043/diff/1/app/views/service.js#newcode21
app/views/service.js:21: var IMPORTED_VIEWLET_CONFIGS = [];
On 2013/07/18 15:17:24, jeff.pihach wrote:
> if (!IMPORTED_VIEWLET_CONFIGS) {
>   var IMPORTED_VIEWLET_CONFIGS = [];
> }

Update coming.

https://codereview.appspot.com/11517043/diff/1/app/views/viewlets/charm-detai...
File app/views/viewlets/charm-details.js (right):

https://codereview.appspot.com/11517043/diff/1/app/views/viewlets/charm-detai...
app/views/viewlets/charm-details.js:53: 'failure': function(data, request) {
On 2013/07/18 14:54:20, benjamin.saller wrote:
> request isn't used

True, but it's passed by the failure mode. I think it's nice to respect the api
and know it's data available to the function call.

[matthew.scott, 2013-07-18 15:32:27]

Please take a look.

[matthew.scott, 2013-07-18 15:47:20]

*** Submitted:

Initial pass at charm details in inspector

This adds the charm details to the inspector, pulling the data from the charm
store when possible.  It uses the existing browser code to display that
information.

R=benjamin.saller, jeff.pihach, rharding
CC=
https://codereview.appspot.com/11517043