Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(911)

Issue 113430043: code review 113430043: go.talks: add OSCON "Gophers with Hammers" talk (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 6 months ago by josharian
Modified:
6 years, 5 months ago
Reviewers:
adg
CC:
adg, campoy, dvyukov, golang-codereviews
Visibility:
Public.

Description

go.talks: add OSCON "Gophers with Hammers" talk

Patch Set 1 #

Patch Set 2 : diff -r 2b96b82cd80d https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 2b96b82cd80d https://code.google.com/p/go.talks #

Total comments: 4

Patch Set 4 : diff -r 72f0884450d9 https://code.google.com/p/go.talks #

Total comments: 4

Patch Set 5 : diff -r 72f0884450d9 https://code.google.com/p/go.talks #

Patch Set 6 : diff -r ad18f921c027 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+638 lines, -0 lines) Patch
A 2014/hammers.slide View 1 chunk +398 lines, -0 lines 0 comments Download
A 2014/hammers/codegen.go View 1 chunk +45 lines, -0 lines 0 comments Download
A 2014/hammers/extractiface.go View 1 chunk +21 lines, -0 lines 0 comments Download
A 2014/hammers/extractpath.go View 1 chunk +21 lines, -0 lines 0 comments Download
A 2014/hammers/findthecode.go View 1 chunk +14 lines, -0 lines 0 comments Download
A 2014/hammers/findtheifacedecl.go View 1 chunk +51 lines, -0 lines 0 comments Download
A 2014/hammers/format.go View 1 chunk +15 lines, -0 lines 0 comments Download
A 2014/hammers/fulltype.go View 1 chunk +32 lines, -0 lines 0 comments Download
A 2014/hammers/importpath.go View 1 chunk +19 lines, -0 lines 0 comments Download
A 2014/hammers/types.go View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9
josharian
Hello adg@golang.org, campoy@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
6 years, 6 months ago (2014-07-22 23:40:28 UTC) #1
josharian
Not sure whether you want this here, but figured I should send it just in ...
6 years, 6 months ago (2014-07-22 23:41:04 UTC) #2
adg
https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide File 2014/hammers.slide (right): https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide#newcode66 2014/hammers.slide:66: * go test -cover show the coverage output? https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide#newcode110 ...
6 years, 6 months ago (2014-07-23 03:40:54 UTC) #3
josharian
PTAL https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide File 2014/hammers.slide (right): https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide#newcode66 2014/hammers.slide:66: * go test -cover On 2014/07/23 03:40:54, adg ...
6 years, 5 months ago (2014-07-23 18:53:53 UTC) #4
adg
LGTM https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide File 2014/hammers.slide (right): https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide#newcode105 2014/hammers.slide:105: ... Also mention the -html flag.
6 years, 5 months ago (2014-07-24 00:33:42 UTC) #5
dvyukov
no images in the file list :( On Wed, Jul 23, 2014 at 3:40 AM, ...
6 years, 5 months ago (2014-07-24 07:36:25 UTC) #6
dvyukov
https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide File 2014/hammers.slide (right): https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide#newcode27 2014/hammers.slide:27: - godep does 'go test -race' qualify
6 years, 5 months ago (2014-07-24 07:41:18 UTC) #7
josharian
> no images in the file list :( Yeah. :( I lack the mad drawing ...
6 years, 5 months ago (2014-07-25 00:57:56 UTC) #8
josharian
6 years, 5 months ago (2014-07-25 01:01:20 UTC) #9
*** Submitted as
https://code.google.com/p/go/source/detail?r=d87541d2d65f&repo=talks ***

go.talks: add OSCON "Gophers with Hammers" talk

LGTM=adg
R=adg, campoy, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/113430043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b