Code review - Issue 113430043: code review 113430043: go.talks: add OSCON "Gophers with Hammers" talkhttps://codereview.appspot.com/2014-07-25T01:01:20+00:00rietveld
Message from unknown
2014-07-22T23:39:04+00:00josharianurn:md5:d19fd56d70ab91aa57532f64440e4c41
Message from unknown
2014-07-22T23:39:09+00:00josharianurn:md5:f42b0b6283e1ccda7359c16b128314d5
Message from unknown
2014-07-22T23:40:19+00:00josharianurn:md5:0d8b3e3a0ba26876f0f54ba88c143688
Message from josharian@gmail.com
2014-07-22T23:40:28+00:00josharianurn:md5:7c36dd7f10fdc80b98e8e446c52cfa26
Hello adg@golang.org, campoy@google.com (cc: golang-codereviews@googlegroups.com),
I'd like you to review this change to
https://code.google.com/p/go.talks
Message from josharian@gmail.com
2014-07-22T23:41:04+00:00josharianurn:md5:071b1dc8c391fefd2280a2169874ed96
Not sure whether you want this here, but figured I should send it just in case. :)
Message from adg@golang.org
2014-07-23T03:40:54+00:00adgurn:md5:ff33d95a8ef6fef64d18ee6e4c550563
https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide
File 2014/hammers.slide (right):
https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide#newcode66
2014/hammers.slide:66: * go test -cover
show the coverage output?
https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide#newcode110
2014/hammers.slide:110: go get github.com/josharian/impl
this tool is great btw, I've already started using it.
Message from unknown
2014-07-23T18:49:58+00:00josharianurn:md5:951236c13c2d0875183517c45c258df2
Message from josharian@gmail.com
2014-07-23T18:53:53+00:00josharianurn:md5:008c6bb5123612aed1ad8c3ed4602fa4
PTAL
https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide
File 2014/hammers.slide (right):
https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide#newcode66
2014/hammers.slide:66: * go test -cover
On 2014/07/23 03:40:54, adg wrote:
> show the coverage output?
Done.
https://codereview.appspot.com/113430043/diff/2/2014/hammers.slide#newcode110
2014/hammers.slide:110: go get github.com/josharian/impl
On 2014/07/23 03:40:54, adg wrote:
> this tool is great btw, I've already started using it.
Cool. :) Someone made a vim plugin for it, too: https://github.com/rhysd/vim-go-impl. I'll probably share it and this talk with golang-nuts if/when it is available at talks.golang.org.
Message from adg@golang.org
2014-07-24T00:33:42+00:00adgurn:md5:c33d51a7780ab0527190f494ca5828a7
LGTM
https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide
File 2014/hammers.slide (right):
https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide#newcode105
2014/hammers.slide:105: ...
Also mention the -html flag.
Message from dvyukov@google.com
2014-07-24T07:36:25+00:00dvyukovurn:md5:b974496367e4fbcd205cbeb02ec5ffe3
no images in the file list :(
On Wed, Jul 23, 2014 at 3:40 AM, <josharian@gmail.com> wrote:
> Reviewers: adg, campoy,
>
> Message:
> Hello adg@golang.org, campoy@google.com (cc:
> golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go.talks
>
>
> Description:
> go.talks: add OSCON "Gophers with Hammers" talk
>
> Please review this at https://codereview.appspot.com/113430043/
>
> Affected files (+617, -0 lines):
> A 2014/hammers.slide
> A 2014/hammers/codegen.go
> A 2014/hammers/extractiface.go
> A 2014/hammers/extractpath.go
> A 2014/hammers/findthecode.go
> A 2014/hammers/findtheifacedecl.go
> A 2014/hammers/format.go
> A 2014/hammers/fulltype.go
> A 2014/hammers/importpath.go
> A 2014/hammers/types.go
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Message from dvyukov@google.com
2014-07-24T07:41:18+00:00dvyukovurn:md5:8def755b961d0ac68ae853f10f0c07f9
https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide
File 2014/hammers.slide (right):
https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide#newcode27
2014/hammers.slide:27: - godep
does 'go test -race' qualify
Message from unknown
2014-07-25T00:54:59+00:00josharianurn:md5:23d37c295577a42a9eabd8c00e0916a6
Message from josharian@gmail.com
2014-07-25T00:57:56+00:00josharianurn:md5:9acb1ad7f53c294709dd376f59341aad
> no images in the file list :(
Yeah. :( I lack the mad drawing skills to make an awesome sledgehammer-wielding gopherzilla.
https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide
File 2014/hammers.slide (right):
https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide#newcode27
2014/hammers.slide:27: - godep
On 2014/07/24 07:41:18, dvyukov wrote:
> does 'go test -race' qualify
This list was mostly focused on tools that work at the AST / codegen level. The race detector requires a much deeper integration than that.
That said, I've added it anyway, just in case a new gopher is using this as a list of tools to learn about. :)
https://codereview.appspot.com/113430043/diff/40001/2014/hammers.slide#newcode105
2014/hammers.slide:105: ...
On 2014/07/24 00:33:41, adg wrote:
> Also mention the -html flag.
Done.
Message from unknown
2014-07-25T01:01:07+00:00josharianurn:md5:19464d9136dcb16e23bff28a3d79afbb
Message from josharian@gmail.com
2014-07-25T01:01:20+00:00josharianurn:md5:fb00ecc3455142b7acca8194ee86e71d
*** Submitted as https://code.google.com/p/go/source/detail?r=d87541d2d65f&repo=talks ***
go.talks: add OSCON "Gophers with Hammers" talk
LGTM=adg
R=adg, campoy, dvyukov
CC=golang-codereviews
https://codereview.appspot.com/113430043