Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(344)

Issue 11328043: Issue 3457: Add NullVoice context (using \partcombine with lyrics). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by Mark Polesky
Modified:
5 years, 4 months ago
Reviewers:
janek, dak, Trevor Daniels, t.daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds a new context, NullVoice, to provide users with an easier way to have shared lyrics among polyphonic voices. http://code.google.com/p/lilypond/issues/detail?id=3457

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporate Trevor's suggestions. #

Patch Set 3 : Rewrite, using a better method. #

Patch Set 4 : Complete rewrite. #

Total comments: 1

Patch Set 5 : Fix compile. #

Patch Set 6 : Replace transparent items with point-stencils. #

Patch Set 7 : Fix an oversight. #

Patch Set 8 : Replace point-stencils with #f. #

Patch Set 9 : Nitpick. #

Patch Set 10 : Minor clarification. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -4 lines) Patch
M Documentation/notation/simultaneous.itely View 1 2 3 2 chunks +12 lines, -4 lines 0 comments Download
M Documentation/notation/vocal.itely View 1 2 3 4 2 chunks +117 lines, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 2 3 4 5 6 7 8 9 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 15
Mark Polesky
Hi folks, here's a patch that adds a new snippet to NR "Automatic part combining": ...
6 years, 4 months ago (2013-07-16 05:49:28 UTC) #1
Trevor Daniels
The length of text going into the NR needs to be constrained. It is already ...
6 years, 4 months ago (2013-07-16 07:12:13 UTC) #2
dak
On 2013/07/16 07:12:13, Trevor Daniels wrote: > https://codereview.appspot.com/11328043/diff/1/Documentation/notation/simultaneous.itely#newcode1052 > Documentation/notation/simultaneous.itely:1052: The @code{\partcombine} command > can ...
6 years, 4 months ago (2013-07-18 20:47:05 UTC) #3
Mark Polesky
On 2013/07/18 20:47:05, dak wrote: > Folks, this is the reference manual, not "obscure hacks ...
6 years, 3 months ago (2013-07-19 06:10:17 UTC) #4
t.daniels_treda.co.uk
markpolesky@gmail.com> wrote Friday, July 19, 2013 7:10 AM > On 2013/07/18 20:47:05, dak wrote: > ...
6 years, 3 months ago (2013-07-19 06:53:48 UTC) #5
dak
On 2013/07/19 06:10:17, Mark Polesky wrote: > On 2013/07/18 20:47:05, dak wrote: > > Folks, ...
6 years, 3 months ago (2013-07-19 08:27:20 UTC) #6
Mark Polesky
On 2013/07/19 08:27:20, dak wrote: > Ok. Is the _output_ from the following what you'd ...
6 years, 3 months ago (2013-07-19 09:42:54 UTC) #7
dak
On 2013/07/19 09:42:54, Mark Polesky wrote: > On 2013/07/19 08:27:20, dak wrote: > > Basically, ...
6 years, 3 months ago (2013-07-19 10:48:43 UTC) #8
Mark Polesky
On 2013/07/19 10:48:43, dak wrote: > > To be clear, there are two separate effects ...
6 years, 3 months ago (2013-07-19 19:35:13 UTC) #9
dak
On 2013/07/19 19:35:13, Mark Polesky wrote: > Is there no way to extract the averages ...
6 years, 3 months ago (2013-07-19 20:04:45 UTC) #10
Mark Polesky
David, I've been playing around with your Devnull workaround, and it's great! An independent "aligner" ...
6 years, 3 months ago (2013-07-20 03:57:31 UTC) #11
Mark Polesky
Here's a patch that adds a new context, NullVoice, to provide users with an easier ...
6 years, 2 months ago (2013-08-24 10:22:30 UTC) #12
Trevor Daniels
LGTM, apart from one suggested change that I'd like to see. https://codereview.appspot.com/11328043/diff/21001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): ...
6 years, 2 months ago (2013-08-24 10:34:40 UTC) #13
janek
LGTM. interesting approach.
6 years, 2 months ago (2013-08-27 08:10:43 UTC) #14
janek
6 years, 2 months ago (2013-08-27 12:58:37 UTC) #15
2013/7/19  <dak@gnu.org>:
> On 2013/07/19 19:35:13, Mark Polesky wrote:
>> Is there no way to extract the averages of the NoteColumn
>> X-positions between two voices?  So given these voices:
>
> Please check out
> <URL:http://code.google.com/p/lilypond/issues/detail?id=3232>.  Its
> original title was "LilyPond should use strict proportional spacing
> between note columns" before people

It was not "people", it was me.

> decided to hijack that issue for
> something else, rename it to something utterly unrelated and then leave
> it alone.

Hey, that's not fair!  Indeed, i sort of hijacked that issue (it
wasn't my intention to hijack it, though) and i apologize for that.
However, i *did write* a fix for this, and as far as i can tell the
fix is sound.  Unfortunately, it didn't make it to master (partly
because it become a part of a bigger patch which didn't get enough
reviews) and now it's waiting for the new stable to be released.

If you'd like, i could separate the fix for this issue from the big
patch and submit it now.

best,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b