Issue 110970046: code review 110970046: ogle: remove gosym from server

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 110970046: code review 110970046: ogle: remove gosym from server (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 9 months ago by r

Modified:
9 years, 9 months ago

Reviewers:
nigeltao

CC:
nigeltao

Visibility:
Public.

Description

ogle: remove gosym from server Use the newly parsed DWARF information instead. Tested on Linux; server's Frames method still works.

Patch Set 1 #

Patch Set 2 : diff -r bad9b3a11146 https://code.google.com/p/ogle #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -39 lines)			Patch
	M	program/server/server.go	View		6 chunks	+19 lines, -39 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle

9 years, 9 months ago (2014-07-09 20:00:40 UTC) #1

9 years, 9 months ago (2014-07-10 17:57:32 UTC) #3

*** Submitted as https://code.google.com/p/ogle/source/detail?r=4f0a7455f8e0 ***

ogle: remove gosym from server
Use the newly parsed DWARF information instead.
Tested on Linux; server's Frames method still works.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/110970046

Expand All Messages | Collapse All Messages