Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1212)

Issue 110970046: code review 110970046: ogle: remove gosym from server (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by r
Modified:
7 years, 4 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle: remove gosym from server Use the newly parsed DWARF information instead. Tested on Linux; server's Frames method still works.

Patch Set 1 #

Patch Set 2 : diff -r bad9b3a11146 https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -39 lines) Patch
M program/server/server.go View 6 chunks +19 lines, -39 lines 0 comments Download

Messages

Total messages: 3
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 4 months ago (2014-07-09 20:00:40 UTC) #1
nigeltao
LGTM.
7 years, 4 months ago (2014-07-10 03:06:38 UTC) #2
r
7 years, 4 months ago (2014-07-10 17:57:32 UTC) #3
*** Submitted as https://code.google.com/p/ogle/source/detail?r=4f0a7455f8e0 ***

ogle: remove gosym from server
Use the newly parsed DWARF information instead.
Tested on Linux; server's Frames method still works.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/110970046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b