Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(179)

Issue 109430043: code review 109430043: ogle: move symbol lookup into dwarf package (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by r
Modified:
7 years, 5 months ago
Reviewers:
nigeltao
CC:
nigeltao
Visibility:
Public.

Description

ogle: move symbol lookup into dwarf package Also add a (trivial) test for PCToLine. Also open up the frame data, as yet unused, in the elf and macho packages.

Patch Set 1 #

Patch Set 2 : diff -r 0418e9debffa https://code.google.com/p/ogle #

Patch Set 3 : diff -r 0418e9debffa https://code.google.com/p/ogle #

Total comments: 12

Patch Set 4 : diff -r 0418e9debffa https://code.google.com/p/ogle #

Total comments: 1

Patch Set 5 : diff -r 0418e9debffa https://code.google.com/p/ogle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -93 lines) Patch
M debug/dwarf/line.go View 1 2 3 4 chunks +7 lines, -6 lines 0 comments Download
A debug/dwarf/pclntab_test.go View 1 2 3 4 1 chunk +134 lines, -0 lines 0 comments Download
A debug/dwarf/symbol.go View 1 2 3 1 chunk +99 lines, -0 lines 0 comments Download
M debug/elf/file.go View 2 chunks +4 lines, -4 lines 0 comments Download
M debug/elf/file_test.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M debug/macho/file.go View 2 chunks +3 lines, -3 lines 0 comments Download
M program/server/dwarf.go View 1 2 3 chunks +4 lines, -79 lines 0 comments Download

Messages

Total messages: 6
r
Hello nigeltao, I'd like you to review this change to https://code.google.com/p/ogle
7 years, 5 months ago (2014-07-02 19:40:14 UTC) #1
nigeltao
https://codereview.appspot.com/109430043/diff/30001/debug/dwarf/line.go File debug/dwarf/line.go (right): https://codereview.appspot.com/109430043/diff/30001/debug/dwarf/line.go#newcode5 debug/dwarf/line.go:5: // Mapping from PC to lines. Is this a ...
7 years, 5 months ago (2014-07-07 05:05:34 UTC) #2
r
Hello nigeltao@golang.org, Please take another look.
7 years, 5 months ago (2014-07-07 17:37:51 UTC) #3
r
https://codereview.appspot.com/109430043/diff/30001/debug/dwarf/line.go File debug/dwarf/line.go (right): https://codereview.appspot.com/109430043/diff/30001/debug/dwarf/line.go#newcode5 debug/dwarf/line.go:5: // Mapping from PC to lines. On 2014/07/07 05:05:33, ...
7 years, 5 months ago (2014-07-07 17:38:05 UTC) #4
nigeltao
LGTM. "go test code.google.com/p/ogle/debug/dwarf" works for me, on linux/amd64. https://codereview.appspot.com/109430043/diff/50001/debug/dwarf/pclntab_test.go File debug/dwarf/pclntab_test.go (right): https://codereview.appspot.com/109430043/diff/50001/debug/dwarf/pclntab_test.go#newcode78 debug/dwarf/pclntab_test.go:78: ...
7 years, 5 months ago (2014-07-08 00:05:39 UTC) #5
r
7 years, 5 months ago (2014-07-08 16:37:54 UTC) #6
*** Submitted as https://code.google.com/p/ogle/source/detail?r=d4c9dc09c25f ***

ogle: move symbol lookup into dwarf package
Also add a (trivial) test for PCToLine.
Also open up the frame data, as yet unused, in the elf and macho packages.

LGTM=nigeltao
R=nigeltao
https://codereview.appspot.com/109430043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b