Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1249)

Unified Diff: debug/elf/file_test.go

Issue 109430043: code review 109430043: ogle: move symbol lookup into dwarf package (Closed)
Patch Set: diff -r 0418e9debffa https://code.google.com/p/ogle Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « debug/elf/file.go ('k') | debug/macho/file.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: debug/elf/file_test.go
===================================================================
--- a/debug/elf/file_test.go
+++ b/debug/elf/file_test.go
@@ -167,11 +167,11 @@
} else {
f, err = Open(tt.file)
}
- defer f.Close()
if err != nil {
t.Errorf("cannot open file %s: %v", tt.file, err)
continue
}
+ defer f.Close()
if !reflect.DeepEqual(f.FileHeader, tt.hdr) {
t.Errorf("open %s:\n\thave %#v\n\twant %#v\n", tt.file, f.FileHeader, tt.hdr)
continue
« no previous file with comments | « debug/elf/file.go ('k') | debug/macho/file.go » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b