code review 10890045: image/color: add Plan9Palette and WebSafePalette.

image/color: add Plan9Palette and WebSafePalette.

[nigeltao, 2013-07-07 12:33:44]

Hello r@golang.org (cc: andybons@gmail.com, golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2013-07-07 23:24:35]

LGTM

https://codereview.appspot.com/10890045/diff/6001/src/pkg/image/color/gen.go
File src/pkg/image/color/gen.go (right):

https://codereview.appspot.com/10890045/diff/6001/src/pkg/image/color/gen.go#...
src/pkg/image/color/gen.go:85: fmt.Println("// of Netscape Navigator. It is also
known as the Netscape Color Cube.")
reference link? there's this. http://en.wikipedia.org/wiki/Web_colors

https://codereview.appspot.com/10890045/diff/6001/src/pkg/image/color/palette.go
File src/pkg/image/color/palette.go (right):

https://codereview.appspot.com/10890045/diff/6001/src/pkg/image/color/palette...
src/pkg/image/color/palette.go:277: // of Netscape Navigator. It is also known
as the Netscape Color Cube.
reference link?

[rsc, 2013-07-08 19:38:00]

Are these important enough to be in the standard library, as opposed to
somewhere in the go.image subrepo?

What needs them?

[Andrew Bonventre, 2013-07-08 19:59:04]

On 2013/07/08 19:38:00, rsc wrote:
> Are these important enough to be in the standard library, as opposed to
> somewhere in the go.image subrepo?
> 
> What needs them?

The GIF writer CL at https://codereview.appspot.com/10896043 was the original
reasoning behind this change.

[rsc, 2013-07-08 20:00:03]

I'm just raising the question. I'll leave the decision to Nigel and Rob.

[nigeltao, 2013-07-09 01:12:31]

On Tue, Jul 9, 2013 at 6:00 AM, Russ Cox <rsc@golang.org> wrote:
> I'm just raising the question. I'll leave the decision to Nigel and Rob.

Rob and I have decided to keep them in the standard library, so that
gif.Encode has a standard color.Palette to use.

In hindsight, maybe all of image/... should be in a go.image repo, but
that wasn't an option at the time and it's too late to change that
now.

[nigeltao, 2013-07-09 09:17:38]

*** Submitted as https://code.google.com/p/go/source/detail?r=06606915c043 ***

image/color: add Plan9Palette and WebSafePalette.

R=r, rsc, andybons
CC=andybons, golang-dev
https://codereview.appspot.com/10890045