Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(775)

Issue 10890045: code review 10890045: image/color: add Plan9Palette and WebSafePalette. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by nigeltao
Modified:
4 years, 4 months ago
Reviewers:
r
CC:
r, rsc, Andrew Bonventre, andybons, golang-dev
Visibility:
Public.

Description

image/color: add Plan9Palette and WebSafePalette.

Patch Set 1 #

Patch Set 2 : diff -r 0d2b8690d896 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0d2b8690d896 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 000ecca1178d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+591 lines, -0 lines) Patch
A src/pkg/image/color/gen.go View 1 2 3 1 chunk +94 lines, -0 lines 0 comments Download
A src/pkg/image/color/palette.go View 1 2 3 1 chunk +497 lines, -0 lines 0 comments Download

Messages

Total messages: 7
nigeltao
Hello r@golang.org (cc: andybons@gmail.com, golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
4 years, 4 months ago (2013-07-07 12:33:44 UTC) #1
r
LGTM https://codereview.appspot.com/10890045/diff/6001/src/pkg/image/color/gen.go File src/pkg/image/color/gen.go (right): https://codereview.appspot.com/10890045/diff/6001/src/pkg/image/color/gen.go#newcode85 src/pkg/image/color/gen.go:85: fmt.Println("// of Netscape Navigator. It is also known ...
4 years, 4 months ago (2013-07-07 23:24:35 UTC) #2
rsc
Are these important enough to be in the standard library, as opposed to somewhere in ...
4 years, 4 months ago (2013-07-08 19:38:00 UTC) #3
Andrew Bonventre
On 2013/07/08 19:38:00, rsc wrote: > Are these important enough to be in the standard ...
4 years, 4 months ago (2013-07-08 19:59:04 UTC) #4
rsc
I'm just raising the question. I'll leave the decision to Nigel and Rob.
4 years, 4 months ago (2013-07-08 20:00:03 UTC) #5
nigeltao
On Tue, Jul 9, 2013 at 6:00 AM, Russ Cox <rsc@golang.org> wrote: > I'm just ...
4 years, 4 months ago (2013-07-09 01:12:31 UTC) #6
nigeltao
4 years, 4 months ago (2013-07-09 09:17:38 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=06606915c043 ***

image/color: add Plan9Palette and WebSafePalette.

R=r, rsc, andybons
CC=andybons, golang-dev
https://codereview.appspot.com/10890045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4