Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(776)

Issue 10896043: image/gif: add writer implementation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Andrew Bonventre
Modified:
4 years, 4 months ago
Reviewers:
nigeltao
CC:
r, nigeltao, golang-dev
Visibility:
Public.

Description

image/gif: add writer implementation

Patch Set 1 #

Patch Set 2 : diff -r 09e39a9ce38e https://code.google.com/p/go #

Total comments: 66

Patch Set 3 : diff -r e334347476c4 https://code.google.com/p/go #

Patch Set 4 : diff -r e334347476c4 https://code.google.com/p/go #

Patch Set 5 : diff -r 84917868ef43 https://code.google.com/p/go #

Patch Set 6 : diff -r fc06b300732a https://code.google.com/p/go #

Patch Set 7 : diff -r c1301713bae7 https://code.google.com/p/go #

Patch Set 8 : diff -r c1301713bae7 https://code.google.com/p/go #

Patch Set 9 : diff -r c1301713bae7 https://code.google.com/p/go #

Patch Set 10 : diff -r c1301713bae7 https://code.google.com/p/go #

Patch Set 11 : diff -r c1301713bae7 https://code.google.com/p/go #

Patch Set 12 : diff -r c1301713bae7 https://code.google.com/p/go #

Total comments: 18

Patch Set 13 : diff -r 26f441a1f78b https://code.google.com/p/go/ #

Total comments: 14

Patch Set 14 : diff -r 26f441a1f78b https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+535 lines, -2 lines) Patch
M src/pkg/go/build/deps_test.go View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/image/gif/reader.go View 1 1 chunk +1 line, -1 line 0 comments Download
A src/pkg/image/gif/writer.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +329 lines, -0 lines 0 comments Download
A src/pkg/image/gif/writer_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +204 lines, -0 lines 0 comments Download
A src/pkg/image/testdata/video-005.gray.gif View 1 Binary file 0 comments Download

Messages

Total messages: 18
Andrew Bonventre
I’ve noticed some hot spots when I benchmarked that I plan to address. The two ...
4 years, 4 months ago (2013-07-02 23:26:52 UTC) #1
nigeltao
https://codereview.appspot.com/10896043/diff/3001/src/pkg/image/gif/mediancut.go File src/pkg/image/gif/mediancut.go (right): https://codereview.appspot.com/10896043/diff/3001/src/pkg/image/gif/mediancut.go#newcode32 src/pkg/image/gif/mediancut.go:32: type point struct { Or just type point [numDimensions]uint32 ...
4 years, 4 months ago (2013-07-03 03:27:24 UTC) #2
nigeltao
Also, please complete a Contributor License Agreement if you haven't already done so: http://golang.org/doc/contribute.html#copyright
4 years, 4 months ago (2013-07-03 03:31:55 UTC) #3
Andrew Bonventre
Thanks for the speedy response, Nigel. Changes made with a question about the API inline. ...
4 years, 4 months ago (2013-07-03 17:19:34 UTC) #4
nigeltao
https://codereview.appspot.com/10896043/diff/3001/src/pkg/image/gif/mediancut.go File src/pkg/image/gif/mediancut.go (right): https://codereview.appspot.com/10896043/diff/3001/src/pkg/image/gif/mediancut.go#newcode150 src/pkg/image/gif/mediancut.go:150: Quantize(m image.Image) (*image.Paletted, error) On 2013/07/03 17:19:35, Andrew Bonventre ...
4 years, 4 months ago (2013-07-03 23:48:04 UTC) #5
Andrew Bonventre
ptal https://codereview.appspot.com/10896043/diff/3001/src/pkg/image/gif/mediancut.go File src/pkg/image/gif/mediancut.go (right): https://codereview.appspot.com/10896043/diff/3001/src/pkg/image/gif/mediancut.go#newcode150 src/pkg/image/gif/mediancut.go:150: Quantize(m image.Image) (*image.Paletted, error) On 2013/07/03 23:48:04, nigeltao ...
4 years, 4 months ago (2013-07-04 04:31:30 UTC) #6
nigeltao
It looks like the median cut algorithm isn't cheap. For a 1000x1000 pixel image, you're ...
4 years, 4 months ago (2013-07-04 07:30:39 UTC) #7
Andrew Bonventre
> Rob and I need to do some more thinking about this, but I'm pretty ...
4 years, 4 months ago (2013-07-04 11:56:26 UTC) #8
nigeltao
On Thu, Jul 4, 2013 at 5:30 PM, <nigeltao@golang.org> wrote: > Encoding full-color image as ...
4 years, 4 months ago (2013-07-07 12:35:04 UTC) #9
nigeltao
On Sun, Jul 7, 2013 at 10:35 PM, Nigel Tao <nigeltao@golang.org> wrote: > On Thu, ...
4 years, 4 months ago (2013-07-11 04:49:54 UTC) #10
Andrew Bonventre
ptal Removed mediancut.go. What is the purpose of returning a color.Palette from Quantize in addition ...
4 years, 4 months ago (2013-07-11 18:37:21 UTC) #11
nigeltao
On Fri, Jul 12, 2013 at 4:37 AM, <andybons@chromium.org> wrote: > What is the purpose ...
4 years, 4 months ago (2013-07-11 22:29:16 UTC) #12
Andrew Bonventre
On 2013/07/11 22:29:16, nigeltao wrote: > On Fri, Jul 12, 2013 at 4:37 AM, <mailto:andybons@chromium.org> ...
4 years, 4 months ago (2013-07-11 23:15:15 UTC) #13
nigeltao
https://codereview.appspot.com/10896043/diff/55003/src/pkg/image/gif/writer.go File src/pkg/image/gif/writer.go (right): https://codereview.appspot.com/10896043/diff/55003/src/pkg/image/gif/writer.go#newcode25 src/pkg/image/gif/writer.go:25: func log2Int256(x int) int { Just call the function ...
4 years, 4 months ago (2013-07-12 00:47:17 UTC) #14
Andrew Bonventre
PTAL https://codereview.appspot.com/10896043/diff/55003/src/pkg/image/gif/writer.go File src/pkg/image/gif/writer.go (right): https://codereview.appspot.com/10896043/diff/55003/src/pkg/image/gif/writer.go#newcode25 src/pkg/image/gif/writer.go:25: func log2Int256(x int) int { On 2013/07/12 00:47:17, ...
4 years, 4 months ago (2013-07-12 01:55:05 UTC) #15
nigeltao
LGTM. I'll make the minor edits and submit. https://codereview.appspot.com/10896043/diff/74001/src/pkg/image/gif/writer.go File src/pkg/image/gif/writer.go (right): https://codereview.appspot.com/10896043/diff/74001/src/pkg/image/gif/writer.go#newcode70 src/pkg/image/gif/writer.go:70: func ...
4 years, 4 months ago (2013-07-12 04:51:04 UTC) #16
Andrew Bonventre
https://codereview.appspot.com/10896043/diff/74001/src/pkg/image/gif/writer.go File src/pkg/image/gif/writer.go (right): https://codereview.appspot.com/10896043/diff/74001/src/pkg/image/gif/writer.go#newcode70 src/pkg/image/gif/writer.go:70: func (b *blockWriter) Write(data []byte) (int, error) { On ...
4 years, 4 months ago (2013-07-12 14:25:54 UTC) #17
nigeltao
4 years, 4 months ago (2013-07-15 00:57:13 UTC) #18
*** Submitted as https://code.google.com/p/go/source/detail?r=58ee92a528da ***

image/gif: add writer implementation

R=r, nigeltao
CC=golang-dev
https://codereview.appspot.com/10896043

Committer: Nigel Tao <nigeltao@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4