Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 108890045: code review 108890045: [release-branch.go1.3] runtime: revise CL 105140044 (de... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by rsc
Modified:
8 years, 7 months ago
Reviewers:
brainman, bradfitz
CC:
golang-codereviews, bradfitz, adg
Visibility:
Public.

Description

[release-branch.go1.3] runtime: revise CL 105140044 (defer nil) to work on Windows ««« CL 105120044 / 824ea5943ba8 runtime: revise CL 105140044 (defer nil) to work on Windows It appears that something about Go on Windows cannot handle the fault cause by a jump to address 0. The way Go represents and calls functions, this never happened at all, until CL 105140044. This CL changes the code added in CL 105140044 to make jump to 0 impossible once again. Fixes issue 8047. (again, on Windows) TBR=bradfitz R=golang-codereviews, dave CC=adg, golang-codereviews, iant, r https://codereview.appspot.com/105120044 »»»

Patch Set 1 #

Patch Set 2 : diff -r aa9d6b4e5c70 https://code.google.com/p/go/ #

Patch Set 3 : diff -r aa9d6b4e5c70 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/pkg/runtime/stack.c View 1 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-codereviews@googlegroups.com (cc: adg), I'd like you to review this change to https://code.google.com/p/go/
8 years, 7 months ago (2014-06-13 01:14:11 UTC) #1
bradfitz
LGTM
8 years, 7 months ago (2014-06-13 01:14:36 UTC) #2
brainman
It builds OK here on both 386 and amd64. I will investigate why test crashes ...
8 years, 7 months ago (2014-06-13 01:30:49 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=67de4afa60e7 *** [release-branch.go1.3] runtime: revise CL 105140044 (defer nil) to work on ...
8 years, 7 months ago (2014-06-13 01:52:51 UTC) #4
brainman
8 years, 7 months ago (2014-06-13 02:52:17 UTC) #5
Message was sent while issue was closed.
On 2014/06/13 01:30:49, brainman wrote:
> ... I will investigate why test crashes
> with no stack trace.

It is a variation of https://code.google.com/p/go/issues/detail?id=8006. We call
function at 0 address, our exception handler is called, but we don't handle
exception, because of this condition
http://tip.golang.org/src/pkg/runtime/os_windows_386.c#L52. So default windows
exception handler is called - Dr Watson or whatever it is called.

I have some ideas about how to fix issue 8006. So I will work on that.

Alex
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b