Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(93)

Issue 105120044: code review 105120044: runtime: revise CL 105140044 (defer nil) to work on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by rsc
Modified:
8 years, 7 months ago
Reviewers:
bradfitz
CC:
dfc, golang-codereviews, adg, iant, r
Visibility:
Public.

Description

runtime: revise CL 105140044 (defer nil) to work on Windows It appears that something about Go on Windows cannot handle the fault cause by a jump to address 0. The way Go represents and calls functions, this never happened at all, until CL 105140044. This CL changes the code added in CL 105140044 to make jump to 0 impossible once again. Fixes issue 8047. (again, on Windows)

Patch Set 1 #

Patch Set 2 : diff -r 1fe8917b8aea https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1fe8917b8aea https://code.google.com/p/go/ #

Patch Set 4 : diff -r aa46f025bb46 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/pkg/runtime/stack.c View 1 2 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-codereviews@googlegroups.com (cc: adg, iant, r), I'd like you to review this change to https://code.google.com/p/go/
8 years, 7 months ago (2014-06-13 01:05:28 UTC) #1
dfc
On 2014/06/13 01:05:28, rsc wrote: > Hello mailto:golang-codereviews@googlegroups.com (cc: adg, iant, r), > > I'd ...
8 years, 7 months ago (2014-06-13 01:07:05 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=824ea5943ba8 *** runtime: revise CL 105140044 (defer nil) to work on Windows ...
8 years, 7 months ago (2014-06-13 01:12:54 UTC) #3
bradfitz
8 years, 7 months ago (2014-06-13 01:14:10 UTC) #4
Message was sent while issue was closed.
LGTM on the web now
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b