|
|
Descriptionopenpgp: Add support for BZIP2-compressed data packets.
Tested using a variety of files encrypted with gpg and the
"--compress-algo BZIP2" gpg option.
Patch Set 1 #Patch Set 2 : diff -r 1f2453f1ed54 https://code.google.com/p/go.crypto #Patch Set 3 : diff -r 1f2453f1ed54 https://code.google.com/p/go.crypto #MessagesTotal messages: 12
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
Sign in to reply to this message.
R=agl On Sat, Jun 29, 2013 at 5:38 PM, <marete@toshnix.com> wrote: > Reviewers: golang-dev1, > > Message: > Hello golang-dev@googlegroups.com, > > I'd like you to review this change to > https://code.google.com/p/go.**crypto<https://code.google.com/p/go.crypto> > > > Description: > openpgp: Add support for BZIP2-compressed data packets. > > Tested using a variety of files encrypted with gpg and the > "--compress-algo BZIP2" gpg option. > > Please review this at https://codereview.appspot.**com/10801043/<https://codereview.appspot.com/108... > > Affected files: > M openpgp/packet/compressed.go > > > Index: openpgp/packet/compressed.go > ==============================**==============================**======= > --- a/openpgp/packet/compressed.go > +++ b/openpgp/packet/compressed.go > @@ -6,6 +6,7 @@ > > import ( > "code.google.com/p/go.crypto/**openpgp/errors<http://code.google.com/p/go.crypto/openpgp/errors> > " > + "compress/bzip2" > "compress/flate" > "compress/zlib" > "io" > @@ -30,6 +31,8 @@ > c.Body = flate.NewReader(r) > case 2: > c.Body, err = zlib.NewReader(r) > + case 3: > + c.Body = bzip2.NewReader(r) > default: > err = errors.UnsupportedError("**unknown compression > algorithm: " + strconv.Itoa(int(buf[0]))) > } > > > -- > > ---You received this message because you are subscribed to the Google > Groups "golang-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou... > . > For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o... > . > > >
Sign in to reply to this message.
LGTM. Have you signed the ICLA? http://golang.org/doc/contribute.html#copyright
Sign in to reply to this message.
I have now signed the copyright assignment agreement. On Tue, Jul 2, 2013 at 8:56 PM, <agl@golang.org> wrote: > LGTM. > > Have you signed the ICLA? > http://golang.org/doc/contribute.html#copyright > > https://codereview.appspot.com/10801043/ -- Brian Gitonga Marete CEO/CTO Toshnix Systems http://toshnix.com
Sign in to reply to this message.
Processed. Leaving for agl to submit. On Tue, Jul 2, 2013 at 3:14 PM, Brian Gitonga Marete <marete@toshnix.com>wrote: > I have now signed the copyright assignment agreement. > > On Tue, Jul 2, 2013 at 8:56 PM, <agl@golang.org> wrote: > > LGTM. > > > > Have you signed the ICLA? > > http://golang.org/doc/contribute.html#copyright > > > > https://codereview.appspot.com/10801043/ > > > > -- > Brian Gitonga Marete > CEO/CTO Toshnix Systems > http://toshnix.com >
Sign in to reply to this message.
*** Submitted as https://code.google.com/p/go/source/detail?r=81eec9b5ce2d&repo=crypto *** openpgp: Add support for BZIP2-compressed data packets. Tested using a variety of files encrypted with gpg and the "--compress-algo BZIP2" gpg option. R=golang-dev, bradfitz, agl CC=golang-dev https://codereview.appspot.com/10801043 Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.
*** Abandoned ***
Sign in to reply to this message.
On Fri, Aug 9, 2013 at 2:56 AM, <marete@toshnix.com> wrote: > *** Abandoned *** > > https://codereview.appspot.com/10801043/ Sorry, not sure what I did there. This patch was accepted and is in the tree. Struggling with hg and codereview :) -- Brian Gitonga Marete CEO/CTO Toshnix Systems http://toshnix.com
Sign in to reply to this message.
You probably want hg change -D, delete locally, not -d, delete remotely. The codereview plugin sometimes suggests the wrong option. Sorry for the foot gun. On 09/08/2013, at 10:01, Brian Gitonga Marete <marete@toshnix.com> wrote: > On Fri, Aug 9, 2013 at 2:56 AM, <marete@toshnix.com> wrote: >> *** Abandoned *** >> >> https://codereview.appspot.com/10801043/ > > Sorry, not sure what I did there. This patch was accepted and is in > the tree. Struggling with hg and codereview :) > > -- > Brian Gitonga Marete > CEO/CTO Toshnix Systems > http://toshnix.com > > -- > > --- > You received this message because you are subscribed to the Google Groups "golang-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > >
Sign in to reply to this message.
On Fri, Aug 9, 2013 at 3:29 AM, Dave Cheney <dave@cheney.net> wrote: > You probably want hg change -D, delete locally, not -d, delete remotely. The codereview plugin sometimes suggests the wrong option. Sorry for the foot gun. > > On 09/08/2013, at 10:01, Brian Gitonga Marete <marete@toshnix.com> wrote: > >> On Fri, Aug 9, 2013 at 2:56 AM, <marete@toshnix.com> wrote: >>> *** Abandoned *** >>> >>> https://codereview.appspot.com/10801043/ >> >> Sorry, not sure what I did there. This patch was accepted and is in >> the tree. Struggling with hg and codereview :) Ah, yes. Indeed I just followed some advice I got after I did a "hg sync" (I think :)). Many thanks Dave Cheney.
Sign in to reply to this message.
On Fri, Aug 9, 2013 at 3:32 AM, Brian Gitonga Marete <marete@toshnix.com> wrote: > On Fri, Aug 9, 2013 at 3:29 AM, Dave Cheney <dave@cheney.net> wrote: >> You probably want hg change -D, delete locally, not -d, delete remotely. The codereview plugin sometimes suggests the wrong option. Sorry for the foot gun. >> >> On 09/08/2013, at 10:01, Brian Gitonga Marete <marete@toshnix.com> wrote: >> >>> On Fri, Aug 9, 2013 at 2:56 AM, <marete@toshnix.com> wrote: >>>> *** Abandoned *** >>>> >>>> https://codereview.appspot.com/10801043/ >>> >>> Sorry, not sure what I did there. This patch was accepted and is in >>> the tree. Struggling with hg and codereview :) > > Ah, yes. Indeed I just followed some advice I got after I did a "hg > sync" (I think :)). Many thanks Dave Cheney. Hello, Please allow me to prefix this by saying that I _really_ wish we were using GIT, by now the standard DVCS for open source projects. Then allow me to ask a question: In GIT, we have topic branches. What is the equivalent facility for hg and codereview? Specifically, if I have a pending CL and I wish to stash the changes associated with that CL (anything like `git stash'?) and work on another topic, what am I to do? I tried to create a branch and commit the pending CL changes to it, but a pre-commit hook associated with codereview will not allow me to do this. Thanks.
Sign in to reply to this message.
Please do not comment on this change thread. There is a fresh 'why aren't we using git thread' on golang-nuts, please comment there. On Mon, Aug 12, 2013 at 4:54 AM, Brian Gitonga Marete <marete@toshnix.com> wrote: > On Fri, Aug 9, 2013 at 3:32 AM, Brian Gitonga Marete <marete@toshnix.com> wrote: >> On Fri, Aug 9, 2013 at 3:29 AM, Dave Cheney <dave@cheney.net> wrote: >>> You probably want hg change -D, delete locally, not -d, delete remotely. The codereview plugin sometimes suggests the wrong option. Sorry for the foot gun. >>> >>> On 09/08/2013, at 10:01, Brian Gitonga Marete <marete@toshnix.com> wrote: >>> >>>> On Fri, Aug 9, 2013 at 2:56 AM, <marete@toshnix.com> wrote: >>>>> *** Abandoned *** >>>>> >>>>> https://codereview.appspot.com/10801043/ >>>> >>>> Sorry, not sure what I did there. This patch was accepted and is in >>>> the tree. Struggling with hg and codereview :) >> >> Ah, yes. Indeed I just followed some advice I got after I did a "hg >> sync" (I think :)). Many thanks Dave Cheney. > > Hello, > > Please allow me to prefix this by saying that I _really_ wish we were > using GIT, by now the standard DVCS for open source projects. > > Then allow me to ask a question: In GIT, we have topic branches. What > is the equivalent facility for hg and codereview? Specifically, if I > have a pending CL and I wish to stash the changes associated with that > CL (anything like `git stash'?) and work on another topic, what am I > to do? > > I tried to create a branch and commit the pending CL changes to it, > but a pre-commit hook associated with codereview will not allow me to > do this. > > Thanks.
Sign in to reply to this message.
|