Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1032)

Issue 10801043: code review 10801043: openpgp: Add support for BZIP2-compressed data packets. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by marete
Modified:
10 years, 7 months ago
Reviewers:
agl1, dfc
CC:
golang-dev, bradfitz, agl1
Visibility:
Public.

Description

openpgp: Add support for BZIP2-compressed data packets. Tested using a variety of files encrypted with gpg and the "--compress-algo BZIP2" gpg option.

Patch Set 1 #

Patch Set 2 : diff -r 1f2453f1ed54 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 1f2453f1ed54 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M openpgp/packet/compressed.go View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12
marete
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
10 years, 9 months ago (2013-06-30 00:38:00 UTC) #1
bradfitz
R=agl On Sat, Jun 29, 2013 at 5:38 PM, <marete@toshnix.com> wrote: > Reviewers: golang-dev1, > ...
10 years, 9 months ago (2013-07-02 14:26:43 UTC) #2
agl1
LGTM. Have you signed the ICLA? http://golang.org/doc/contribute.html#copyright
10 years, 9 months ago (2013-07-02 17:56:16 UTC) #3
marete
I have now signed the copyright assignment agreement. On Tue, Jul 2, 2013 at 8:56 ...
10 years, 9 months ago (2013-07-02 22:14:50 UTC) #4
bradfitz
Processed. Leaving for agl to submit. On Tue, Jul 2, 2013 at 3:14 PM, Brian ...
10 years, 9 months ago (2013-07-03 03:36:05 UTC) #5
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=81eec9b5ce2d&repo=crypto *** openpgp: Add support for BZIP2-compressed data packets. Tested using a ...
10 years, 9 months ago (2013-07-03 15:31:29 UTC) #6
marete
*** Abandoned ***
10 years, 7 months ago (2013-08-08 23:56:20 UTC) #7
marete
On Fri, Aug 9, 2013 at 2:56 AM, <marete@toshnix.com> wrote: > *** Abandoned *** > ...
10 years, 7 months ago (2013-08-09 00:01:40 UTC) #8
dfc
You probably want hg change -D, delete locally, not -d, delete remotely. The codereview plugin ...
10 years, 7 months ago (2013-08-09 00:29:16 UTC) #9
marete
On Fri, Aug 9, 2013 at 3:29 AM, Dave Cheney <dave@cheney.net> wrote: > You probably ...
10 years, 7 months ago (2013-08-09 00:33:11 UTC) #10
marete
On Fri, Aug 9, 2013 at 3:32 AM, Brian Gitonga Marete <marete@toshnix.com> wrote: > On ...
10 years, 7 months ago (2013-08-11 18:55:00 UTC) #11
dfc
10 years, 7 months ago (2013-08-11 21:38:03 UTC) #12
Please do not comment on this change thread. There is a fresh 'why
aren't we using git thread' on golang-nuts, please comment there.

On Mon, Aug 12, 2013 at 4:54 AM, Brian Gitonga Marete
<marete@toshnix.com> wrote:
> On Fri, Aug 9, 2013 at 3:32 AM, Brian Gitonga Marete <marete@toshnix.com>
wrote:
>> On Fri, Aug 9, 2013 at 3:29 AM, Dave Cheney <dave@cheney.net> wrote:
>>> You probably want hg change -D, delete locally, not -d, delete remotely. The
codereview plugin sometimes suggests the wrong option. Sorry for the foot gun.
>>>
>>> On 09/08/2013, at 10:01, Brian Gitonga Marete <marete@toshnix.com> wrote:
>>>
>>>> On Fri, Aug 9, 2013 at 2:56 AM,  <marete@toshnix.com> wrote:
>>>>> *** Abandoned ***
>>>>>
>>>>> https://codereview.appspot.com/10801043/
>>>>
>>>> Sorry, not sure what I did there. This patch was accepted and is in
>>>> the tree. Struggling with hg and codereview :)
>>
>> Ah, yes. Indeed I just followed some advice I got after I did a "hg
>> sync" (I think :)). Many thanks Dave Cheney.
>
> Hello,
>
> Please allow me to prefix this by saying that I _really_ wish we were
> using GIT, by now the standard DVCS for open source projects.
>
> Then allow me to ask a question: In GIT, we have topic branches. What
> is the equivalent facility for hg and codereview? Specifically, if I
> have a pending CL and I wish to stash the changes associated with that
> CL (anything like `git stash'?) and work on another topic, what am I
> to do?
>
> I tried to create a branch and commit the pending CL changes to it,
> but a pre-commit hook associated with codereview will not allow me to
> do this.
>
> Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b