Issue 106920044: Port conflict resolutions & HM9000

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 106920044: Port conflict resolutions & HM9000

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by johnsca

Modified:
9 years, 10 months ago

Reviewers:
mp+222672, benjamin.saller

Visibility:
Public.

Description

Port conflict resolutions & HM9000 https://code.launchpad.net/~johnsca/charms/bundles/cloudfoundry/port-conflicts/+merge/222672 (do not edit description out of merge proposal)

Patch Set 2 : Bundle changes to resolve port conflicts #

Total comments: 1

Patch Set 3 : Bundle changes to resolve port conflicts #

Patch Set 4 : Port conflict resolutions & HM9000 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -34 lines)			Patch
	A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	bundles.yaml	View	1 2 3	3 chunks	+19 lines, -34 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

benjamin.saller

LGTM with minors https://codereview.appspot.com/106920044/diff/1/bundles.yaml File bundles.yaml (right): https://codereview.appspot.com/106920044/diff/1/bundles.yaml#newcode81 bundles.yaml:81: outgoing_port: 8082 the options come back ...

9 years, 10 months ago (2014-06-11 22:43:31 UTC) #2

benjamin.saller

LGTM https://codereview.appspot.com/106920044/diff/20001/bundles.yaml File bundles.yaml (right): https://codereview.appspot.com/106920044/diff/20001/bundles.yaml#newcode50 bundles.yaml:50: - ['logrouter:loggregator', [loggregator]] cool, thanks for sorting this

9 years, 10 months ago (2014-06-12 16:26:20 UTC) #4

johnsca

9 years, 10 months ago (2014-06-12 18:57:23 UTC) #5

*** Submitted:

Port conflict resolutions & HM9000

R=benjamin.saller
CC=
https://codereview.appspot.com/106920044

Expand All Messages | Collapse All Messages