Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 106920044: Port conflict resolutions & HM9000

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by johnsca
Modified:
8 years ago
Reviewers:
mp+222672, benjamin.saller
Visibility:
Public.

Description

Port conflict resolutions & HM9000 https://code.launchpad.net/~johnsca/charms/bundles/cloudfoundry/port-conflicts/+merge/222672 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Bundle changes to resolve port conflicts #

Total comments: 1

Patch Set 3 : Bundle changes to resolve port conflicts #

Patch Set 4 : Port conflict resolutions & HM9000 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -34 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M bundles.yaml View 1 2 3 3 chunks +19 lines, -34 lines 0 comments Download

Messages

Total messages: 5
johnsca
Please take a look.
8 years ago (2014-06-10 15:56:20 UTC) #1
benjamin.saller
LGTM with minors https://codereview.appspot.com/106920044/diff/1/bundles.yaml File bundles.yaml (right): https://codereview.appspot.com/106920044/diff/1/bundles.yaml#newcode81 bundles.yaml:81: outgoing_port: 8082 the options come back ...
8 years ago (2014-06-11 22:43:31 UTC) #2
johnsca
Please take a look.
8 years ago (2014-06-12 14:13:45 UTC) #3
benjamin.saller
LGTM https://codereview.appspot.com/106920044/diff/20001/bundles.yaml File bundles.yaml (right): https://codereview.appspot.com/106920044/diff/20001/bundles.yaml#newcode50 bundles.yaml:50: - ['logrouter:loggregator', [loggregator]] cool, thanks for sorting this
8 years ago (2014-06-12 16:26:20 UTC) #4
johnsca
8 years ago (2014-06-12 18:57:23 UTC) #5
*** Submitted:

Port conflict resolutions & HM9000

R=benjamin.saller
CC=
https://codereview.appspot.com/106920044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b