Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(72)

Issue 105950044: code review 105950044: undo CL 101970047 / 30307cc8bef2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rsc
Modified:
11 years ago
Reviewers:
josharian
CC:
golang-codereviews
Visibility:
Public.

Description

undo CL 101970047 / 30307cc8bef2 makes windows-amd64-race benchmarks slower ««« original CL description testing: make benchmarking faster Allow the number of benchmark iterations to grow faster for fast benchmarks, and don't round up twice. Using the default benchtime, this CL reduces wall clock time to run benchmarks: net/http 49s -> 37s (-24%) runtime 8m31s -> 5m55s (-30%) bytes 2m37s -> 1m29s (-43%) encoding/json 29s -> 21s (-27%) strings 1m16s -> 53s (-30%) LGTM=crawshaw R=golang-codereviews, crawshaw CC=golang-codereviews https://codereview.appspot.com/101970047 »»»

Patch Set 1 #

Patch Set 2 : diff -r 5e6f44d8e195 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M src/pkg/testing/benchmark.go View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello josharian@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years ago (2014-06-13 06:03:49 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=deffcd96d549 *** undo CL 101970047 / 30307cc8bef2 makes windows-amd64-race benchmarks slower ««« ...
11 years ago (2014-06-13 06:03:55 UTC) #2
josharian
11 years ago (2014-06-13 15:22:09 UTC) #3
Message was sent while issue was closed.
LGTM

Thank you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b