Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(398)

Issue 101970047: code review 101970047: testing: make benchmarking faster (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by josharian
Modified:
11 years ago
Reviewers:
gobot, rsc, crawshaw
CC:
golang-codereviews, crawshaw
Visibility:
Public.

Description

testing: make benchmarking faster Allow the number of benchmark iterations to grow faster for fast benchmarks, and don't round up twice. Using the default benchtime, this CL reduces wall clock time to run benchmarks: net/http 49s -> 37s (-24%) runtime 8m31s -> 5m55s (-30%) bytes 2m37s -> 1m29s (-43%) encoding/json 29s -> 21s (-27%) strings 1m16s -> 53s (-30%)

Patch Set 1 #

Patch Set 2 : diff -r ae4861ef1935 https://code.google.com/p/go #

Patch Set 3 : diff -r 6146799f32ed https://code.google.com/p/go #

Patch Set 4 : diff -r d011c0dcae9c https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/pkg/testing/benchmark.go View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5
josharian
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years ago (2014-06-11 00:51:03 UTC) #1
crawshaw
LGTM Looks like all tests are still run with n=1 and n=101, which is protection ...
11 years ago (2014-06-11 19:13:18 UTC) #2
josharian
*** Submitted as https://code.google.com/p/go/source/detail?r=30307cc8bef2 *** testing: make benchmarking faster Allow the number of benchmark iterations ...
11 years ago (2014-06-12 14:51:32 UTC) #3
gobot
This CL appears to have broken the windows-amd64-race builder. See http://build.golang.org/log/7be4b697f4a924e4f336bb110cfcb5e125ab427e
11 years ago (2014-06-12 15:52:17 UTC) #4
rsc
11 years ago (2014-06-13 05:33:47 UTC) #5
Message was sent while issue was closed.
I'm pretty sure this is killing the windows-amd64-race builder.
There are lots of data points now, and it all started with this CL.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b