Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 10571043: code review 10571043: crypto/sha1: provide a top-level Sum function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by r
Modified:
4 years, 4 months ago
Reviewers:
rsc
CC:
golang-dev, rsc, bradfitz
Visibility:
Public.

Description

crypto/sha1: provide a top-level Sum function Makes it easy to ask the simple question, what is the hash of this data?

Patch Set 1 #

Patch Set 2 : diff -r 0bca1d8683f5 https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r 0bca1d8683f5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/pkg/crypto/sha1/sha1.go View 2 chunks +14 lines, -2 lines 0 comments Download
M src/pkg/crypto/sha1/sha1_test.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
4 years, 4 months ago (2013-06-25 21:29:43 UTC) #1
r
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
4 years, 4 months ago (2013-06-25 21:37:16 UTC) #2
rsc
LGTM
4 years, 4 months ago (2013-06-25 21:44:20 UTC) #3
bradfitz
https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go File src/pkg/crypto/sha1/sha1.go (right): https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go#newcode131 src/pkg/crypto/sha1/sha1.go:131: func Sum(data []byte) [Size]byte { goapi doesn't handle this: ...
4 years, 4 months ago (2013-06-25 21:45:17 UTC) #4
r
https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go File src/pkg/crypto/sha1/sha1.go (right): https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go#newcode131 src/pkg/crypto/sha1/sha1.go:131: func Sum(data []byte) [Size]byte { On 2013/06/25 21:45:17, bradfitz ...
4 years, 4 months ago (2013-06-25 21:49:22 UTC) #5
bradfitz
On Tue, Jun 25, 2013 at 2:49 PM, <r@golang.org> wrote: > > https://codereview.appspot.**com/10571043/diff/4001/src/** > pkg/crypto/sha1/sha1.go<https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go> ...
4 years, 4 months ago (2013-06-25 22:10:54 UTC) #6
r
Size is a constant, so [Size]uint8 is a Go type. goapi isn't resolving the name ...
4 years, 4 months ago (2013-06-25 22:45:24 UTC) #7
bradfitz
Yes, I'm just saying that goapi is broken. On Tue, Jun 25, 2013 at 3:45 ...
4 years, 4 months ago (2013-06-25 22:49:40 UTC) #8
rsc
[Size]byte is probably fine even for goapi. If Size changes, goapi will tell us. There's ...
4 years, 4 months ago (2013-06-25 22:56:01 UTC) #9
r
4 years, 4 months ago (2013-06-26 00:04:21 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=d3f99f091748 ***

crypto/sha1: provide a top-level Sum function
Makes it easy to ask the simple question, what is the hash of this data?

R=golang-dev, rsc, bradfitz
CC=golang-dev
https://codereview.appspot.com/10571043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4