code review 10571043: crypto/sha1: provide a top-level Sum function

crypto/sha1: provide a top-level Sum function
Makes it easy to ask the simple question, what is the hash of this data?

[r, 2013-06-25 21:29:43]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[r, 2013-06-25 21:37:16]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2013-06-25 21:44:20]

LGTM

[bradfitz, 2013-06-25 21:45:17]

https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go
File src/pkg/crypto/sha1/sha1.go (right):

https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go...
src/pkg/crypto/sha1/sha1.go:131: func Sum(data []byte) [Size]byte {
goapi doesn't handle this:

+pkg crypto/sha1, func Sum([]uint8) [Size]uint8

But why in just sha1? Why not md5, sha256, sha512?

[r, 2013-06-25 21:49:22]

https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go
File src/pkg/crypto/sha1/sha1.go (right):

https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go...
src/pkg/crypto/sha1/sha1.go:131: func Sum(data []byte) [Size]byte {
On 2013/06/25 21:45:17, bradfitz wrote:
> goapi doesn't handle this:
> 
> +pkg crypto/sha1, func Sum([]uint8) [Size]uint8
> 
> But why in just sha1? Why not md5, sha256, sha512?

i plan to put its analog in all the hash packages. if all you need is a hash,
the current API is clunky.

what do you mean, goapi doesn't handle it? it prints out the addition just fine.

[bradfitz, 2013-06-25 22:10:54]

On Tue, Jun 25, 2013 at 2:49 PM, <r@golang.org> wrote:

>
> https://codereview.appspot.**com/10571043/diff/4001/src/**
>
pkg/crypto/sha1/sha1.go<https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go>
> File src/pkg/crypto/sha1/sha1.go (right):
>
> https://codereview.appspot.**com/10571043/diff/4001/src/**
>
pkg/crypto/sha1/sha1.go#**newcode131<https://codereview.appspot.com/10571043/diff/4001/src/pkg/crypto/sha1/sha1.go#newcode131>
> src/pkg/crypto/sha1/sha1.go:**131: func Sum(data []byte) [Size]byte {
> On 2013/06/25 21:45:17, bradfitz wrote:
>
>> goapi doesn't handle this:
>>
>
>  +pkg crypto/sha1, func Sum([]uint8) [Size]uint8
>>
>
>  But why in just sha1? Why not md5, sha256, sha512?
>>
>
> what do you mean, goapi doesn't handle it? it prints out the addition
> just fine.
>

[Size]uint8 isn't a Go type.

It should say [20]uint8.

[r, 2013-06-25 22:45:24]

Size is a constant, so [Size]uint8 is a Go type. goapi isn't resolving
the name right.

It should not say [20]uint8 since the constant is defined in the
package for a reason: it is the size of this return value.
-rob

[bradfitz, 2013-06-25 22:49:40]

Yes, I'm just saying that goapi is broken.



On Tue, Jun 25, 2013 at 3:45 PM, Rob Pike <r@golang.org> wrote:

> Size is a constant, so [Size]uint8 is a Go type. goapi isn't resolving
> the name right.
>
> It should not say [20]uint8 since the constant is defined in the
> package for a reason: it is the size of this return value.
> -rob
>

[rsc, 2013-06-25 22:56:01]

[Size]byte is probably fine even for goapi. If Size changes, goapi will
tell us.
There's a false positive if we rewrite [Size]byte to [20]byte later, but no
big deal.

Russ

[r, 2013-06-26 00:04:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=d3f99f091748 ***

crypto/sha1: provide a top-level Sum function
Makes it easy to ask the simple question, what is the hash of this data?

R=golang-dev, rsc, bradfitz
CC=golang-dev
https://codereview.appspot.com/10571043