Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 10483043: code review 10483043: go.talks/pkg/present: read lines with bufio.Scanner (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by adg
Modified:
7 years, 7 months ago
Reviewers:
dsymonds
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

go.talks/pkg/present: read lines with bufio.Scanner This should handle "\r\n" line endings properly. Fixes issue 5339.

Patch Set 1 #

Patch Set 2 : diff -r f142c9f666d9 https://code.google.com/p/go.talks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M pkg/present/parse.go View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks
7 years, 7 months ago (2013-06-24 03:34:26 UTC) #1
dsymonds
LGTM
7 years, 7 months ago (2013-06-24 04:07:59 UTC) #2
adg
7 years, 7 months ago (2013-06-24 04:19:01 UTC) #3
*** Submitted as
https://code.google.com/p/go/source/detail?r=b99d8b2510ba&repo=talks ***

go.talks/pkg/present: read lines with bufio.Scanner

This should handle "\r\n" line endings properly.

Fixes issue 5339.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/10483043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b