Issue 10483043: code review 10483043: go.talks/pkg/present: read lines with bufio.Scanner

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 10483043: code review 10483043: go.talks/pkg/present: read lines with bufio.Scanner (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by adg

Modified:
10 years, 10 months ago

Reviewers:
dsymonds

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

go.talks/pkg/present: read lines with bufio.Scanner This should handle "\r\n" line endings properly. Fixes issue 5339.

Patch Set 1 #

Patch Set 2 : diff -r f142c9f666d9 https://code.google.com/p/go.talks #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	pkg/present/parse.go	View		2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.talks

10 years, 10 months ago (2013-06-24 03:34:26 UTC) #1

adg

10 years, 10 months ago (2013-06-24 04:19:01 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=b99d8b2510ba&repo=talks ***

go.talks/pkg/present: read lines with bufio.Scanner

This should handle "\r\n" line endings properly.

Fixes issue 5339.

R=golang-dev, dsymonds
CC=golang-dev
https://codereview.appspot.com/10483043

Expand All Messages | Collapse All Messages