Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 104770046: code review 104770046: cmd/objdump: add arm disassembler (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by rsc
Modified:
7 years ago
Reviewers:
minux, iant
CC:
minux, iant, golang-codereviews
Visibility:
Public.

Description

cmd/objdump: add arm disassembler Fixes issue 7452.

Patch Set 1 #

Patch Set 2 : diff -r 95cc2b2ebec5 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 95cc2b2ebec5 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ae4861ef1935 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 37503193c6a2 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 1af13552a260 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 7 : diff -r 5dd1aec48e8f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10868 lines, -17 lines) Patch
M src/cmd/objdump/Makefile View 1 1 chunk +5 lines, -0 lines 0 comments Download
A src/cmd/objdump/armasm.go View 1 2 3 4 1 chunk +10821 lines, -0 lines 0 comments Download
M src/cmd/objdump/main.go View 1 5 chunks +41 lines, -15 lines 0 comments Download
M src/cmd/objdump/objdump_test.go View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello minux (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
7 years ago (2014-05-31 14:09:28 UTC) #1
minux
LGTM.
7 years ago (2014-06-01 07:25:45 UTC) #2
minux
Note: I didn't review the automatically generated file, so please wait for review of the ...
7 years ago (2014-06-01 07:47:39 UTC) #3
rsc
On Sun, Jun 1, 2014 at 3:47 AM, minux <minux@golang.org> wrote: > Note: I didn't ...
7 years ago (2014-06-01 18:52:15 UTC) #4
iant
LGTM https://codereview.appspot.com/104770046/diff/90001/src/cmd/objdump/armasm.go File src/cmd/objdump/armasm.go (right): https://codereview.appspot.com/104770046/diff/90001/src/cmd/objdump/armasm.go#newcode748 src/cmd/objdump/armasm.go:748: arm_ModeThumb You'll need Thumb2 at some point.
7 years ago (2014-06-01 22:46:09 UTC) #5
rsc
https://codereview.appspot.com/104770046/diff/90001/src/cmd/objdump/armasm.go File src/cmd/objdump/armasm.go (right): https://codereview.appspot.com/104770046/diff/90001/src/cmd/objdump/armasm.go#newcode748 src/cmd/objdump/armasm.go:748: arm_ModeThumb On 2014/06/01 22:46:09, iant wrote: > You'll need ...
7 years ago (2014-06-01 22:47:30 UTC) #6
rsc
7 years ago (2014-06-01 22:52:32 UTC) #7
*** Submitted as https://code.google.com/p/go/source/detail?r=498ac2e68c28 ***

cmd/objdump: add arm disassembler

Fixes issue 7452.

LGTM=minux, iant
R=minux, iant
CC=golang-codereviews
https://codereview.appspot.com/104770046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b