Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(338)

Issue 10387043: Use the virtualevn for bin/test-charm.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by benji
Modified:
6 years, 9 months ago
Reviewers:
bac, gary.poster, mp+170063
Visibility:
Public.

Description

Use the virtualevn for bin/test-charm. The python-selenium package in Raring is not new enough, so we will use the virtualenv with an updated version instead. https://code.launchpad.net/~benji/juju-gui/fix-tests/+merge/170063 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use the virtualevn for bin/test-charm. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M Makefile View 1 chunk +3 lines, -1 line 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M bin/test-charm View 1 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5
benji
Please take a look.
6 years, 9 months ago (2013-06-18 12:18:14 UTC) #1
gary.poster
LGTM. Doc suggestions. Thanks! Gary https://codereview.appspot.com/10387043/diff/1/bin/test-charm File bin/test-charm (right): https://codereview.appspot.com/10387043/diff/1/bin/test-charm#newcode19 bin/test-charm:19: # This script expects ...
6 years, 9 months ago (2013-06-18 12:25:59 UTC) #2
bac
LGTM, thx
6 years, 9 months ago (2013-06-18 12:27:27 UTC) #3
benji
Thanks for the reviews. https://codereview.appspot.com/10387043/diff/1/bin/test-charm File bin/test-charm (right): https://codereview.appspot.com/10387043/diff/1/bin/test-charm#newcode19 bin/test-charm:19: # This script expects that ...
6 years, 9 months ago (2013-06-18 12:34:43 UTC) #4
benji
6 years, 9 months ago (2013-06-18 12:39:58 UTC) #5
*** Submitted:

Use the virtualevn for bin/test-charm.

The python-selenium package in Raring is not new enough, so we will use the
virtualenv with an updated version instead.

R=gary.poster, bac
CC=
https://codereview.appspot.com/10387043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b