Use the virtualevn for bin/test-charm.

Use the virtualevn for bin/test-charm.

The python-selenium package in Raring is not new enough, so we will use the
virtualenv with an updated version instead.

https://code.launchpad.net/~benji/juju-gui/fix-tests/+merge/170063

(do not edit description out of merge proposal)

[benji, 2013-06-18 12:18:14]

Please take a look.

[gary.poster, 2013-06-18 12:25:59]

LGTM.  Doc suggestions.  Thanks!

Gary

https://codereview.appspot.com/10387043/diff/1/bin/test-charm
File bin/test-charm (right):

https://codereview.appspot.com/10387043/diff/1/bin/test-charm#newcode19
bin/test-charm:19: # This script expects that the system has python-shelltoolbox
and juju
s/juju/pyJuju/ ?

https://codereview.appspot.com/10387043/diff/1/bin/test-charm#newcode25
bin/test-charm:25: # recognized, especially --origin and --charm.
recognized.  --origin and --charm are especially useful.  See
docs/continuous-integration.rst for more information.

[bac, 2013-06-18 12:27:27]

LGTM, thx

[benji, 2013-06-18 12:34:43]

Thanks for the reviews.

https://codereview.appspot.com/10387043/diff/1/bin/test-charm
File bin/test-charm (right):

https://codereview.appspot.com/10387043/diff/1/bin/test-charm#newcode19
bin/test-charm:19: # This script expects that the system has python-shelltoolbox
and juju
On 2013/06/18 12:26:00, gary.poster wrote:
> s/juju/pyJuju/ ?

It does seem to use py-juju right now so I'll make that clear. (It doesn't look
like it will be hard to change that when we decide to.)

[benji, 2013-06-18 12:39:58]

*** Submitted:

Use the virtualevn for bin/test-charm.

The python-selenium package in Raring is not new enough, so we will use the
virtualenv with an updated version instead.

R=gary.poster, bac
CC=
https://codereview.appspot.com/10387043