Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(187)

Issue 10264044: code review 10264044: runtime: preempt goroutines for GC (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 5 months ago by dvyukov
Modified:
4 years, 4 months ago
Reviewers:
rsc
CC:
golang-dev, DMorsing, rsc
Visibility:
Public.

Description

runtime: preempt goroutines for GC The last patch for preemptive scheduler, with this change stoptheworld issues preemption requests every 100us. Update issue 543.

Patch Set 1 #

Patch Set 2 : diff -r 4068527655f3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 4068527655f3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 4068527655f3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 4068527655f3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 4068527655f3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r 4068527655f3 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r 4fe0404effd1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 9 : diff -r 4fe0404effd1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 10 : diff -r 4fe0404effd1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 11 : diff -r 4fe0404effd1 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 9

Patch Set 12 : diff -r e98b1f7169c5 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 13 : diff -r e98b1f7169c5 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 4

Patch Set 14 : diff -r e98b1f7169c5 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 15 : diff -r 166d946fa77f https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -15 lines) Patch
M src/pkg/runtime/proc.c View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 4 chunks +13 lines, -7 lines 0 comments Download
M src/pkg/runtime/proc_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +30 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/stack.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +6 lines, -5 lines 0 comments Download
M src/pkg/runtime/stack.c View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 23
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
4 years, 5 months ago (2013-06-13 15:21:00 UTC) #1
dvyukov
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
4 years, 5 months ago (2013-06-13 15:21:05 UTC) #2
dvyukov
On 2013/06/13 15:21:05, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > Please take another ...
4 years, 5 months ago (2013-06-17 11:32:19 UTC) #3
DMorsing
Is this intended for go 1.2? I haven't seen its inclusion mentioned anywhere. I'll take ...
4 years, 5 months ago (2013-06-17 11:54:24 UTC) #4
dvyukov
On Mon, Jun 17, 2013 at 3:54 PM, <daniel.morsing@gmail.com> wrote: > Is this intended for ...
4 years, 5 months ago (2013-06-17 12:01:31 UTC) #5
rsc
Does this depend on any other pending CLs, or are all its prerequisites submitted already? ...
4 years, 5 months ago (2013-06-17 12:05:55 UTC) #6
dvyukov
On Mon, Jun 17, 2013 at 4:05 PM, Russ Cox <rsc@golang.org> wrote: > Does this ...
4 years, 5 months ago (2013-06-17 12:07:47 UTC) #7
rsc
I'm very happy to see this coming to completion, and I will review this CL. ...
4 years, 5 months ago (2013-06-17 12:31:03 UTC) #8
dvyukov
Hello golang-dev@googlegroups.com, daniel.morsing@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
4 years, 4 months ago (2013-06-27 18:07:58 UTC) #9
dvyukov
synced to tip ready for review
4 years, 4 months ago (2013-06-27 18:08:37 UTC) #10
dvyukov
There is one functionality that was there, but I don't know yet how to implement ...
4 years, 4 months ago (2013-06-27 18:12:10 UTC) #11
rsc
On 2013/06/27 18:12:10, dvyukov wrote: > There is one functionality that was there, but I ...
4 years, 4 months ago (2013-06-27 19:17:06 UTC) #12
rsc
https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/proc.c#newcode386 src/pkg/runtime/proc.c:386: // wait for remaining P's to stop voluntary voluntarily ...
4 years, 4 months ago (2013-06-27 19:37:53 UTC) #13
dvyukov
On Thu, Jun 27, 2013 at 11:17 PM, <rsc@golang.org> wrote: > On 2013/06/27 18:12:10, dvyukov ...
4 years, 4 months ago (2013-06-27 19:47:51 UTC) #14
dvyukov
On Thu, Jun 27, 2013 at 11:37 PM, <rsc@golang.org> wrote: > > https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/proc.c > File ...
4 years, 4 months ago (2013-06-27 19:54:45 UTC) #15
rsc
https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/stack.c File src/pkg/runtime/stack.c (right): https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/stack.c#newcode200 src/pkg/runtime/stack.c:200: How about, right here, // If we are preempted ...
4 years, 4 months ago (2013-06-27 20:00:41 UTC) #16
rsc
https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/stack.c File src/pkg/runtime/stack.c (right): https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/stack.c#newcode200 src/pkg/runtime/stack.c:200: To be clear, what I meant by "safe" is ...
4 years, 4 months ago (2013-06-27 20:20:17 UTC) #17
dvyukov
PTAL https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/proc.c#newcode386 src/pkg/runtime/proc.c:386: // wait for remaining P's to stop voluntary ...
4 years, 4 months ago (2013-06-27 21:07:41 UTC) #18
rsc
https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/stack.h File src/pkg/runtime/stack.h (right): https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/stack.h#newcode110 src/pkg/runtime/stack.h:110: StackPreempt = (uintptr)(intptr)(int32)0xfffffade, This cannot be an enum. Also, ...
4 years, 4 months ago (2013-06-27 21:08:41 UTC) #19
rsc
https://codereview.appspot.com/10264044/diff/45002/src/pkg/runtime/proc_test.go File src/pkg/runtime/proc_test.go (right): https://codereview.appspot.com/10264044/diff/45002/src/pkg/runtime/proc_test.go#newcode160 src/pkg/runtime/proc_test.go:160: // The function is used to test preemption at ...
4 years, 4 months ago (2013-06-27 21:10:45 UTC) #20
dvyukov
PTAL https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/stack.h File src/pkg/runtime/stack.h (right): https://codereview.appspot.com/10264044/diff/30001/src/pkg/runtime/stack.h#newcode110 src/pkg/runtime/stack.h:110: StackPreempt = (uintptr)(intptr)(int32)0xfffffade, On 2013/06/27 21:08:41, rsc wrote: ...
4 years, 4 months ago (2013-06-27 21:18:15 UTC) #21
rsc
LGTM Please wait until tomorrow to submit. I'd like the builders to catch up and ...
4 years, 4 months ago (2013-06-27 21:21:36 UTC) #22
dvyukov
4 years, 4 months ago (2013-06-28 13:52:36 UTC) #23
*** Submitted as https://code.google.com/p/go/source/detail?r=575afd15c877 ***

runtime: preempt goroutines for GC
The last patch for preemptive scheduler,
with this change stoptheworld issues preemption
requests every 100us.
Update issue 543.

R=golang-dev, daniel.morsing, rsc
CC=golang-dev
https://codereview.appspot.com/10264044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4