Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 10253055: Fix CI tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by gary.poster
Modified:
7 years, 5 months ago
Reviewers:
rharding, mp+169502, jeff.pihach
Visibility:
Public.

Description

Fix CI tests https://code.launchpad.net/~gary/juju-gui/fix-charm-panel-tests/+merge/169502 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix CI tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -19 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 1 chunk +3 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/sidebar.handlebars View 1 1 chunk +3 lines, -0 lines 0 comments Download
M app/templates/browser-search.handlebars View 1 1 chunk +3 lines, -0 lines 0 comments Download
M app/templates/charm-token.handlebars View 1 chunk +3 lines, -0 lines 0 comments Download
M test/test_charm_running.py View 1 chunk +39 lines, -19 lines 0 comments Download

Messages

Total messages: 5
gary.poster
Please take a look.
7 years, 5 months ago (2013-06-14 17:17:19 UTC) #1
rharding
LGTM with small notes. https://codereview.appspot.com/10253055/diff/1/test/test_charm_running.py File test/test_charm_running.py (right): https://codereview.appspot.com/10253055/diff/1/test/test_charm_running.py#newcode119 test/test_charm_running.py:119: def get_search_box(driver): is there any ...
7 years, 5 months ago (2013-06-14 17:26:32 UTC) #2
jeff.pihach
LGTM Thanks for taking over and fixing it up :) https://codereview.appspot.com/10253055/diff/1/app/subapps/browser/templates/browser_charm.handlebars File app/subapps/browser/templates/browser_charm.handlebars (right): https://codereview.appspot.com/10253055/diff/1/app/subapps/browser/templates/browser_charm.handlebars#newcode15 ...
7 years, 5 months ago (2013-06-14 17:41:20 UTC) #3
gary.poster
On 2013/06/14 17:26:32, rharding wrote: > LGTM with small notes. > > https://codereview.appspot.com/10253055/diff/1/test/test_charm_running.py > File ...
7 years, 5 months ago (2013-06-14 18:13:27 UTC) #4
gary.poster
7 years, 5 months ago (2013-06-14 18:19:21 UTC) #5
*** Submitted:

Fix CI tests

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/10253055
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b