Fix CI tests

Fix CI tests



https://code.launchpad.net/~gary/juju-gui/fix-charm-panel-tests/+merge/169502

(do not edit description out of merge proposal)

[gary.poster, 2013-06-14 17:17:19]

Please take a look.

[rharding, 2013-06-14 17:26:32]

LGTM with small notes.

https://codereview.appspot.com/10253055/diff/1/test/test_charm_running.py
File test/test_charm_running.py (right):

https://codereview.appspot.com/10253055/diff/1/test/test_charm_running.py#new...
test/test_charm_running.py:119: def get_search_box(driver):
is there any reason to go through search vs the default interesting data
enpoint? Just to verify that search is working?

https://codereview.appspot.com/10253055/diff/1/test/test_charm_running.py#new...
test/test_charm_running.py:121: return
driver.find_element_by_css_selector('[name=bws-search]')
so bws-search is another key we need to make sure to not change. I know there
was talk of re-designing the search area of the sidebar at some point. Please
update it with the same notes on breaking CI if it changes.

[jeff.pihach, 2013-06-14 17:41:20]

LGTM Thanks for taking over and fixing it up :)

https://codereview.appspot.com/10253055/diff/1/app/subapps/browser/templates/...
File app/subapps/browser/templates/browser_charm.handlebars (right):

https://codereview.appspot.com/10253055/diff/1/app/subapps/browser/templates/...
app/subapps/browser/templates/browser_charm.handlebars:15: the other one too! }}
Good idea with the comment!

[gary.poster, 2013-06-14 18:13:27]

On 2013/06/14 17:26:32, rharding wrote:
> LGTM with small notes.
> 
> https://codereview.appspot.com/10253055/diff/1/test/test_charm_running.py
> File test/test_charm_running.py (right):
> 
>
https://codereview.appspot.com/10253055/diff/1/test/test_charm_running.py#new...
> test/test_charm_running.py:119: def get_search_box(driver):
> is there any reason to go through search vs the default interesting data
> enpoint? Just to verify that search is working?

At least in theory, this is a utility that lets you deploy arbitrary charms.  My
goal was to duplicate the previous behavior--or at least the advertised behavior
:-) .

But yeah, even beyond that, this is in service of some integration tests.  I
figured searching was not a bad thing in that context.

>
https://codereview.appspot.com/10253055/diff/1/test/test_charm_running.py#new...
> test/test_charm_running.py:121: return
> driver.find_element_by_css_selector('[name=bws-search]')
> so bws-search is another key we need to make sure to not change. I know there
> was talk of re-designing the search area of the sidebar at some point. Please
> update it with the same notes on breaking CI if it changes.

Done, thanks.

[gary.poster, 2013-06-14 18:19:21]

*** Submitted:

Fix CI tests

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/10253055