Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(594)

Issue 102320044: code review 102320044: syscall: implement syscall.Getppid() on Windows

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by inconshreveable
Modified:
3 years, 5 months ago
Reviewers:
gobot, brainman, ality, 0intro, wandakkelly
CC:
golang-codereviews, shreveal, iant
Visibility:
Public.

Description

syscall: implement syscall.Getppid() on Windows Also added a test to verify os.Getppid() works across all platforms

Patch Set 1 #

Patch Set 2 : diff -r a507dd224581 https://code.google.com/p/go #

Patch Set 3 : diff -r d9c3411f6146 https://code.google.com/p/go #

Total comments: 12

Patch Set 4 : diff -r d9c3411f6146 https://code.google.com/p/go #

Patch Set 5 : diff -r d9c3411f6146 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -2 lines) Patch
M src/pkg/os/os_test.go View 1 2 3 4 1 chunk +26 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_windows.go View 1 2 3 2 chunks +33 lines, -2 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 2 chunks +40 lines, -0 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_amd64.go View 1 2 chunks +40 lines, -0 lines 0 comments Download
M src/pkg/syscall/ztypes_windows.go View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 18
inconshreveable
Hello golang-dev@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
3 years, 5 months ago (2014-06-12 19:04:10 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
3 years, 5 months ago (2014-06-12 19:05:52 UTC) #2
brainman
Looks reasonable. Please, see my comments. Thank you. Alex https://codereview.appspot.com/102320044/diff/40001/src/pkg/os/os_test.go File src/pkg/os/os_test.go (right): https://codereview.appspot.com/102320044/diff/40001/src/pkg/os/os_test.go#newcode1298 src/pkg/os/os_test.go:1298: ...
3 years, 5 months ago (2014-06-13 00:43:50 UTC) #3
shreveal
https://codereview.appspot.com/102320044/diff/40001/src/pkg/os/os_test.go File src/pkg/os/os_test.go (right): https://codereview.appspot.com/102320044/diff/40001/src/pkg/os/os_test.go#newcode1304 src/pkg/os/os_test.go:1304: cmd.Env = []string{"GO_WANT_HELPER_PROCESS=1"} This was essentially copied from helperCommand ...
3 years, 5 months ago (2014-06-13 06:32:13 UTC) #4
inconshreveable
On 2014/06/13 06:32:13, shreveal wrote: > https://codereview.appspot.com/102320044/diff/40001/src/pkg/os/os_test.go > File src/pkg/os/os_test.go (right): > > https://codereview.appspot.com/102320044/diff/40001/src/pkg/os/os_test.go#newcode1304 > ...
3 years, 5 months ago (2014-06-13 06:34:52 UTC) #5
inconshreveable
On 2014/06/13 06:34:52, inconshreveable wrote: > On 2014/06/13 06:32:13, shreveal wrote: > > https://codereview.appspot.com/102320044/diff/40001/src/pkg/os/os_test.go > ...
3 years, 5 months ago (2014-06-13 06:37:44 UTC) #6
brainman
On 2014/06/13 06:32:13, shreveal wrote: > This was essentially copied from helperCommand in os/exec/exec_test.go which ...
3 years, 5 months ago (2014-06-13 07:07:42 UTC) #7
shreveal
On 2014/06/13 07:07:42, brainman wrote: > On 2014/06/13 06:32:13, shreveal wrote: > > This was ...
3 years, 5 months ago (2014-06-13 18:13:45 UTC) #8
brainman
LGTM Can someone with access to contributor license agreement submissions change CONTRIBUTORS file? Thank you. ...
3 years, 5 months ago (2014-06-14 02:30:18 UTC) #9
iant
On 2014/06/14 02:30:18, brainman wrote: > > Can someone with access to contributor license agreement ...
3 years, 5 months ago (2014-06-14 04:09:40 UTC) #10
brainman
On 2014/06/14 04:09:40, iant wrote: > Done. Thank you. Alex
3 years, 5 months ago (2014-06-14 05:27:20 UTC) #11
brainman
*** Submitted as https://code.google.com/p/go/source/detail?r=927f0508bc93 *** syscall: implement syscall.Getppid() on Windows Also added a test to ...
3 years, 5 months ago (2014-06-14 05:51:19 UTC) #12
gobot
This CL appears to have broken the plan9-386-cnielsen builder. See http://build.golang.org/log/adebbf1b2bceca755ef9fe2122462e7e0bf834ff
3 years, 5 months ago (2014-06-14 06:01:18 UTC) #13
brainman
On 2014/06/14 06:01:18, gobot wrote: > This CL appears to have broken the plan9-386-cnielsen builder. ...
3 years, 5 months ago (2014-06-14 06:41:36 UTC) #14
0intro
> > This CL appears to have broken the plan9-386-cnielsen builder. > > See > ...
3 years, 5 months ago (2014-06-14 07:41:15 UTC) #15
ality
David du Colombier <0intro@gmail.com> once said: > Yes, it seems Getppid() always return 0 on ...
3 years, 5 months ago (2014-06-14 12:43:45 UTC) #16
wandakkelly_gmail.com
https://groups.google.com/forum/#!topic/granite-bathroom/ia9NqQzCMFI เมื่อ วันศุกร์ที่ 13 มิถุนายน ค.ศ. 2014, 2 นาฬิกา 5 นาที 53 วินาที UTC+7, go...@golang.org ...
3 years, 5 months ago (2014-06-14 18:05:29 UTC) #17
wandakkelly_gmail.com
3 years, 5 months ago (2014-06-15 04:12:15 UTC) #18
https://groups.google.com/forum/#!forum/granite-bathroom

เมื่อ วันศุกร์ที่ 13 มิถุนายน ค.ศ. 2014, 2 นาฬิกา 5 นาที 53 วินาที UTC+7, 
go...@golang.org เขียนว่า:
>
> Replacing golang-dev with golang-codereviews. 
>
> To the author of this CL: 
>
> If you are using 'hg mail -r golang-dev' to mail the CL, use simply 'hg 
> mail' instead. 
>
> If you did not name golang-dev explicitly and it was still added to the 
> CL, 
> it means your working copy of the repo has a stale codereview.cfg 
> (or lib/codereview/codereview.cfg). 
> Please run 'hg sync' to update your client to the most recent 
> codereview.cfg. 
> If the most recent codereview.cfg has defaultcc set to golang-dev 
> instead of 
> golang-codereviews, please send a CL correcting it. 
>
> Thanks very much. 
>
>
> https://codereview.appspot.com/102320044/ 
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4